Small numerical error in mass flux regridding

sdeastham commented 5 months ago

Name and Institution (Required)

Name: Seb Eastham Institution: Imperial College London

Confirm you have reviewed the following documentation

[x] Support guidelines
[x] User manuals
[x] Debugging GEOS-Chem and HEMCO errors
[x] Current and past Github issues

Description of your issue or question

There is a small bug in the algorithm used to handle regridding of mass fluxes between resolutions, where an edge length multiplication is missing (see https://github.com/GEOS-ESM/MAPL/issues/1199). This error is resolved by some work done by Tom Clune in https://github.com/GEOS-ESM/MAPL/pull/2056 (partially described in https://github.com/GEOS-ESM/MAPL/pull/1202).

lizziel commented 4 months ago

I implemented the changes in https://github.com/GEOS-ESM/MAPL/pull/2056 and compared before and after using GEOS-FP mass fluxes. The result is no differences in diagnostics and restart files.

lizziel commented 2 weeks ago

I revisited this after discussion with Tom Clune at GMAO. I pared down the updates in https://github.com/GEOS-ESM/MAPL/pull/2056 to only what we need and tried again. I now see differences, although I suspect the issue before what error on my part in putting in the update.

Here is an example of differences in daily mean after a 1-day run.

This update can go into 14.4.1 and I will create a PR.

lizziel commented 2 weeks ago

See MAPL PR https://github.com/geoschem/MAPL/pull/36 for this update.

geoschem / GCHP