Closed jahwilson closed 2 years ago
Hi @jahwilson. Thanks for reporting this issue. I have been able to reproduce it on my end and am looking into a fix.
Thanks @msulprizio!
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.
I am finally back to looking at this. I think the issue has to do with the manual diagnostics defined in hcoi_gc_diagn_mod.F90
. According to HEMCO.log the diagnostics are defined but not ever updated and so the diagnostics remain zero.
Successfully added diagnostic CH4_OIL to collection 3
ThisDiagn%AreaScal = 1.0000000000000000
ThisDiagn%MassScal = 0.0000000000000000
Successfully added diagnostic CH4_GAS to collection 3
ThisDiagn%AreaScal = 1.0000000000000000
ThisDiagn%MassScal = 0.0000000000000000
...
Successfully updated diagnostics: EmisCH4_Total (counter: 1)
HEMCO WARNING: Diagnostics counter is zero - return empty array: CH4_OIL
--> LOCATION: DiagnCont_PrepareOutput (hco_diagn_mod.F90)
HEMCO WARNING: Diagnostics counter is zero - return empty array: CH4_GAS
--> LOCATION: DiagnCont_PrepareOutput (hco_diagn_mod.F90)
...
Both CH4 and Hg have similarly defined diagnostics in that module so I think this may also be causing the Hg diagnostic issues described in https://github.com/geoschem/geos-chem/issues/895 and https://github.com/geoschem/geos-chem/issues/1011.
I traced the issue to the following line in hco_calc_mod.F90:
In commit https://github.com/geoschem/HEMCO/commit/057363277fc0820ee7d4828ccbd23c4308b9992b which contained updated for the GCHP adjoint, COL=-1
was changed to COL=HcoState%Diagn%HcoDiagnIDDefault
. This commit was included in HEMCO 3.0.0 / GEOS-Chem 13.1.0. Reverting to COL=-1
appears to resolve the issue so the manual diagnostics are then updated. I can submit a pull request for this fix.
A fix has now been implemented via commit https://github.com/geoschem/HEMCO/pull/121/commits/a9357c297ad6d0752ceda4a81b7f2fed2c3d8150 (currently in the bugfix/ManualDiags
branch), which will ideally go into HEMCO 3.3.1 / GEOS-Chem 13.3.3.
@jahwilson Please try adding this fix to your code and let us know if you have any issues.
@jahwilson I also noticed while investigating this issue that you have both JPL_WETCHARTS : true
and CH4_WETLANDS : on
. Please note that this will cause double counting of wetland emissions in your simulations. The CH4_WETLANDS option (i.e. the HEMCO CH4 wetlands extension) is quite old and may be considered obsolete. We at Harvard recommend using the JPL WetCharts emissions instead. The reference for those emissions is:
Bloom, A.A., K. Bowman, M. Lee, A.J. Turner, R. Schroeder, J.R. Worden, R.J. Weidner, K.C. McDonald, and D.J. Jacob. 2017. CMS: Global 0.5-deg Wetland Methane Emissions and Uncertainty (WetCHARTs v1.0). ORNL DAAC, Oak Ridge, Tennessee, USA. https://doi.org/10.3334/ORNLDAAC/1502.
Hi @msulprizio, that is excellent news - thanks so much for fixing this!
Also thanks for the heads up, I will be sure to turn off the CH4_WETLANDS
option and use JPL_WETCHARTS
instead.
This should now be fixed in GEOS-Chem 13.3.3, which uses HEMCO 3.2.2.
I am having a problem running CH4 speciality simulations. Although the simulations run, average CH4 concentrations drop by around 150 ppb every year. It appears that no CH4 is actually being emitted during the simulation.
HEMCO appears to open and read the emissions inventories correctly. For example, values of
EmisCH4_Total
in the HEMCO diagnostic files are non-zero. However, the section inrun.log
related to the subroutineEMISSCH4
shows thatCH4_EMIS
values are zero. Likewise, theCH4emission
values are zero in the Metrics output files. As a consequence, when I runmetrics.py
, the CH4 total lifetimes return 'inf' values.Before blaming a bug, I just want to check I have not made a mistake in my
HEMCO_Diagn.rc
input! Are CH4 emissions somehow disabled by default and I have not turned them on in my input files?EmisCH4_Total in HEMCO diagnostics output
CH4emission in Metrics output
HEMCO_Diagn.rc
Your HEMCO version and runtime environment:
Input and log files to attach
Additional context