geoschem / HEMCO

The Harmonized Emissions Component (HEMCO), developed by the GEOS-Chem Support Team.
https://hemco.readthedocs.io
Other
16 stars 32 forks source link

Fix incorrect longitude definition in HEMCO_sa_Grid.025x0625.rc and HEMCO_sa_Grid.05x0625.rc #229

Closed yantosca closed 1 year ago

yantosca commented 1 year ago

Name and Institution (Required)

Name: Bob Yantosca Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is the companion update to issue #228 by @nicholasbalasus. This fixes incorrect longitude definitions XMIN and XMAX in the HEMCO_sa_Grid.025x03125.rc and HEMCO_sa_Grid.05x0625.rc. Please see issue #228 for discussion.

Also added explanatory comments to make it clear that the XMIN, XMAX, YMIN, YMAX are edges of the grid.

# Emission grid specifications:
XMIN: -180.15625   # Westernmost longitude edge
XMAX:  179.84375   # Easternmost longitude edge
YMIN: -90.0        # Southernmost latitude edge
YMAX:  90.0        # Northernmost latititude edge
NX: 1152           # Number of longitudes in grid
NY: 721            # Number of latitudes in grid
NZ: 47             # Number of levels in grid

Expected changes

This only affects HEMCO standalone simulations using 0.25x0.3125 or 0.5x0.625 grids. For these simulations, the horizontal grid will now be correct.

Reference(s)

NA

Related Github Issue(s)

yantosca commented 1 year ago

After merging on top of PR https://github.com/geoschem/geos-chem/pull/1879, and HEMCO PR #227, all GEOS-Chem Classic integration tests passed, except TOMAS (which is a known issue that will be fixed later):

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #def9df2 GEOS-Chem submod update: Convert GC netCDF routines to netCDF-F90
GEOS-Chem #5d7b850b4 Merge PR #1884 (Updates for GEOS-Chem in GEOS)
HEMCO     #477c7e8 Merge PR #229 (Fix incorrect longitude definitions for HEMCO standalone)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 63750168
==============================================================================

Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....FAIL
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....FAIL
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 24
Execution tests failed: 2
Execution tests not yet completed: 0

Furthermore, all integration tests were zero-diff w/r/t https://github.com/geoschem/geos-chem/pulls1879, and HEMCO PR #227

Checking gc_05x0625_NA_47L_merra2_fullchem -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS15 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS40 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_aerosol -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_carbon -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_CH4 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_CO2 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_aciduptake -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_APM -> 2 differences found in OutputDir

Checking gc_4x5_merra2_fullchem_benchmark -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA_SVPOA -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_LuoWd -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_marinePOA -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_RRTMG -> 1 difference found in OutputDir

Checking gc_4x5_merra2_Hg -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_metals -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_POPs_BaP -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_tagCH4 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_tagCO -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_tagO3 -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers -> No differences in OutputDir -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers_LuoWd -> No differences in OutputDir -> No differences in Restarts

yantosca commented 1 year ago

After merging on top of PR https://github.com/geoschem/geos-chem/pull/1879 and PR #227, all GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCClassic #3ca40a9 GEOS-Chem submod update: Convert GC netCDF routines to netCDF-F90
GEOS-Chem #5d7b850b4 Merge PR #1884 (Updates for GEOS-Chem in GEOS)
HEMCO     #477c7e8 Merge PR #229 (Fix incorrect longitude definitions for HEMCO standalone)

Number of execution tests: 5

Submitted as SLURM job: 63752023
==============================================================================

Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all integration tests were zero-diff w/r/t PR #1879:

Checking gchp_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_RRTMG
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts