search

geoschem / HEMCO

The Harmonized Emissions Component (HEMCO), developed by the GEOS-Chem Support Team.
https://hemco.readthedocs.io
Other
15 stars 31 forks source link

Fix bug in volcano extension causing crash when volcano turned off #230

Closed lizziel closed 11 months ago

lizziel commented 11 months ago

Name and Institution (Required)

Name: Lizzie Lundgren Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

This update fixes a problem where the simulation will crash in the volcano extension init subroutine on non-root threads if the volcano extension is turned off, such as in the transport tracer simulation. The fix moves the return if extension number is zero to directly after the call to retrieve extension number. This is the same handling as all other HEMCO extension initialization routines.

Expected changes

The model will not crash if the volcano extension is turned off.

Reference(s)

none

Related Github Issue(s)

https://github.com/geoschem/GCHP/issues/331

lizziel commented 11 months ago

Note I did not make an edit to the changelog since the bug came in with 14.2.0 alpha.16, in PR https://github.com/geoschem/HEMCO/pull/221 in which I bracketed new code for printing to log in an amIRoot block.

msulprizio commented 11 months ago

All GCClassic and GCHP integration tests for this PR have passed. I will now merge it into dev/3.7.0.