geoschem / HEMCO

The Harmonized Emissions Component (HEMCO), developed by the GEOS-Chem Support Team.
https://hemco.readthedocs.io
Other
15 stars 31 forks source link

rename HEMCO_Config.rc.sample to HEMCO_Config.rc #245

Closed nicholasbalasus closed 7 months ago

nicholasbalasus commented 8 months ago

Name and Institution (Required)

Name: Nick Balasus Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

In createRunDir.sh, users are given the option to type ./HEMCO_Config.rc.sample if they do not have a HEMCO_Config.rc file. Currently, HEMCO_Config.rc.sample is copied directly without changing the name, meaning this code does not run successfully because HEMCO_Config.rc does not exist.

https://github.com/geoschem/HEMCO/blob/00aaf656934963d64d283a8e6c302743f62942e1/run/createRunDir.sh#L366-L368

To fix this, I rename HEMCO_Config.rc.sample to HEMCO_Config.rc. This is consistent with what is done for HEMCO_Diagn.rc.

https://github.com/geoschem/HEMCO/blob/00aaf656934963d64d283a8e6c302743f62942e1/run/createRunDir.sh#L310

Expected changes

Only to HEMCO standalone run directory creations where the user specifies ./HEMCO_Config.rc.sample.

Reference(s)

n/a

Related Github Issue(s)

n/a

yantosca commented 7 months ago

All GEOS-Chem Classic integration tests (except TOMAS) passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #f5b5694 Merge branch 'docs/dev' into dev/14.2.2
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Using 24 OpenMP threads
Number of execution tests: 27

Submitted as SLURM job: 10285010
==============================================================================

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2                # <==== TOMAS15 and TOMAS40
Execution tests not yet completed: 0

All GEOS-Chem Classic integration tests were zero-diff w/r/t 14.2.2, except TOMAS (failed), APM (parallelization issues) and RRTMG (parallelization issue in diagnostic output).

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

gchp      #074494e GEOS-Chem submodule update: Merge PR #2009 fixing links to RTD
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Number of execution tests: 5

Submitted as SLURM job: 10285450
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP integration tests were also zero-diff w/r/t 14.2.2.