search

geoschem / HEMCO

The Harmonized Emissions Component (HEMCO), developed by the GEOS-Chem Support Team.
https://hemco.readthedocs.io
Other
17 stars 33 forks source link

Turn off emission extensions when EMISSIONS logical is set to false #250

Closed msulprizio closed 11 months ago

msulprizio commented 11 months ago

Name and Institution (Required)

Name: Melissa Sulprizio Institution: Harvard / GCST

Describe the update

The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still on, they get called in HEMCO and result in the model crashing because the input data can't be found.

This is now fixed by adding a check in subroutine ExtSwitch2Buffer (in hco_config_mod.F90) to see if EMISSIONS is set and using that to define a local logical DoEmis. In that same routine, if DoEmis is false then all emission extensions will be defined with Enabled = .FALSE. to avoid calling them during the run stage of HEMCO.

Addresses https://github.com/geoschem/HEMCO/issues/249.

Expected changes

This fix will result in zero differences in out-of-the-box simulations because EMISSIONS is set to true by default in all simulations.

Related Github Issue(s)

yantosca commented 11 months ago

All GEOS-Chem Classic integration tests (except for TOMAS) passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #026388b HEMCO submod update: Include script to change HEMCO version numbers
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO     #7e36ad3 Merge PR #250 (Turn off emission extensions when EMISSIONS is off )

Using 24 OpenMP threads
Number of execution tests: 27

Submitted as SLURM job: 11020335
============================================================================== 

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0

Also all integration tests were identical to the integration tests for PR #2042 except for:

yantosca commented 11 months ago

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #fe78a2b HEMCO submod update: Include script to change HEMCO version numbers
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO     #7e36ad3 Merge PR #250 (Turn off emission extensions when EMISSIONS is off )

Number of execution tests: 5

Submitted as SLURM job: 11020520
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All integration tests were also zero-diff w/r/t the integration test for PR #2042.

lizziel commented 11 months ago

Related issue: https://github.com/geoschem/geos-chem/issues/1420

lizziel commented 11 months ago

I verified this works in GCHP fullchem and transport tracers simulations.