Allow up to 10 nested brackets in the HEMCO_Config.rc file

yantosca commented 6 months ago

Name and Institution (Required)

Name: Bob Yantosca Institution: Harvard + GCST

Confirm you have reviewed the following documentation

[x] Contributing guidelines

Describe the update

In this PR, we have updated the MAXBRACKNEST parameter setting from 5 to 10 in the BracketCheck routine of src/Core/hco_config_mod.F90. This update is needed to account for additional nested brackets, because bracket conditions do not recognize the .and. operator.

Expected changes

This is a zero-diff update. It should allow HEMCO_Config.rc files with more than 5 nested brackets (such as we have in https://github.com/geoschem/geos-chem/pull/2171) to be parsed without error.

Related Github Issue(s)

Needed for https://github.com/geoschem/geos-chem/pull/2171

yantosca commented 6 months ago

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #e43be93 GEOS-Chem submod update: Merge PR #2178 (Rename "native" to "raw" )
GEOS-Chem #67220bb52 Merge PR #2178 (Rename "native" to "raw" in GCHP rundir scripts)
HEMCO     #7933a1b Increase allowed # of nested brackets from 5 to 10

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 23201447
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all integration tests were zero-diff w/r/t 14.3.0, except:

APM (known parallelization issue)
RRTMG (numerical noise in RRTMG collection file)

yantosca commented 6 months ago

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #4bceb23 7GEOS-Chem submod update: Merge PR #2178 (Rename "native" to "raw" )
GEOS-Chem #67220bb52 Merge PR #2178 (Rename "native" to "raw" in GCHP rundir scripts)
HEMCO     #7933a1b Increase allowed # of nested brackets from 5 to 10

Number of execution tests: 6

Submitted as SLURM job: 23202467
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all GCHP integration tests were zero-diff w/r/t 14.3.0

geoschem / HEMCO