search

geoschem / HEMCO

The Harmonized Emissions Component (HEMCO), developed by the GEOS-Chem Support Team.
https://hemco.readthedocs.io
Other
15 stars 31 forks source link

Handle 3D NEI emissions #268

Closed nicholasbalasus closed 3 months ago

nicholasbalasus commented 3 months ago

Name and Institution (Required)

Name: Nick Balasus Institution: Harvard

Confirm you have reviewed the following documentation

Describe the update

Modifies src/Core/hco_interp_mod.F90 to handle 3D emissions from NEI. The handling is now that if the emissions are 3, 11, or 36 levels, they are assumed to be GEOS-Chem levels. 3 and 11 levels are NEI emissions and 36 levels are AEIC emissions. This is not the prettiest fix so let me know what you think @jimmielin @yantosca. This update was necessary because of the changes made in https://github.com/geoschem/HEMCO/commit/daf54d07ed16d0948302070855468b6b27fdd9a5.

Expected changes

If merged with https://github.com/geoschem/geos-chem/pull/2213, NEI emissions should work again. Thanks to @Lukemonr for finding this issue.

Reference(s)

n/a

Related Github Issue(s)

https://github.com/geoschem/HEMCO/issues/264

jimmielin commented 3 months ago

Thanks @nicholasbalasus for the fix. I remember that before when the levels were hardcoded the files had a metadata attribute with the level unit being "GEOS-Chem level". That's what we check for in CESM/WRF code. Can I ask if the 3D NEI emissions no longer have this attribute?

nicholasbalasus commented 3 months ago

Good point, @jimmielin. They do have this attribute and that used to be part of the IsModelLevel check. I removed that in https://github.com/geoschem/HEMCO/commit/daf54d07ed16d0948302070855468b6b27fdd9a5 in part because I wasn't aware that files like the AEIC and NEI emissions existed.

yantosca commented 3 months ago

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #8b8ac95 GEOS-Chem submod update: Merge PR #2187 (Update intgration/parallel tests)
GEOS-Chem #53635e9f1 Merge PR #2213 (Change NEI 2D emissions to xy dimension)
HEMCO     #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 24860287
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all integration tests were zero-diff w/r/t 14.3.0, except:

yantosca commented 3 months ago

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #def016b GEOS-Chem submod update: Merge PR #2187 (Update intgration/parallel tests)
GEOS-Chem #53635e9f1 Merge PR #2213 (Change NEI 2D emissions to xy dimension)
HEMCO     #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)

Number of execution tests: 6

Submitted as SLURM job: 24861290
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all tests were zero-diff w/r/t GCHP 14.3.0.

yantosca commented 3 months ago

Closing, as this PR is already merged into the HEMCO "no-diff-to-benchmark" development stream. Thanks @nicholasbalasus!