search

geoschem / gcpy

Python toolkit for GEOS-Chem. Contains basic plotting scripts, plus the suite of GEOS-Chem benchmarking utilities.
https://gcpy.readthedocs.io
Other
51 stars 24 forks source link

GCPy 1.4.1 usages of seaborn-talk is deprecated in older matplotlib versions #282

Closed lizziel closed 9 months ago

lizziel commented 10 months ago

Name and Institution (Required)

Name: Lizzie Lundgren Institution: Harvard University

Description of your issue or question

I recently created a new GCPy environment to use with GCPy 1.4.1. The environment.yml file does not specify version for matplotlib and the version retrieved using my package manager was 3.3.2. This version is not compatible with the seaborn-talk implementation in GCPy. I suggest specifying a minimum version of matplotlib within the environment.yml file.

Incidentally, I got around this issue by removing the examples/timeseries/ files in GCPy. These examples are general python examples and are not documented on GCPy's ReadTheDocs. I suggest deleting these as they introduce potential for package conflicts and may also simply get out-of-date.

yantosca commented 10 months ago

This will be fixed by PR #283

yantosca commented 9 months ago

We can close this since PR #283 has been merged.