search

geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
167 stars 162 forks source link

[BUG/ISSUE] Unused line of code in KPP rate law function #1132

Closed ktravis213 closed 2 years ago

ktravis213 commented 2 years ago

What institution are you from?

NASA LaRC

Description of the problem

I think the following on line 570 in fullchem_RateLawFuncs.F90 is not needed, it doesn't appear to be used or part of the JPL equation: r0 = a0 ( 1.0_dp + 0.6_dp 9.871E7_dp * PRESS )

yantosca commented 2 years ago

Thanks @ktravis213. I believe that you are right. I can remove that line, as it'll avoid useless computations. Thanks for finding this!

msulprizio commented 2 years ago

I'm moving this to 13.4.0 since it is still a work in progress and we will be making other fixes to the chemistry mechanism

yantosca commented 2 years ago

This should be a no-diff update as we are taking out a line of code that isn't used.

msulprizio commented 2 years ago

This fix has now been implemented in 3e8166d and will be included in GEOS-Chem 13.4.0.