geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
162 stars 155 forks source link

[BUG/ISSUE] HEMCO config template for GCHP not setting Volcano_Table correctly #1350

Closed kilicomu closed 1 year ago

kilicomu commented 1 year ago

What institution are you from?

Wolfson Atmospheric Chemistry Laboratories

Description of the problem

I think the Volcano_Table value in HEMCO_Config.rc as generated for GCHP run directories through createRunDir.sh is not being set correctly by default, and is missing $YYYY$MM$DD due to unescaped $ characters. I think the offending line is:

https://github.com/geoschem/geos-chem/blob/7e51a0674aba638c8322fef493ac9251095e8cf4/run/GCHP/createRunDir.sh#L232

and that it should be:

RUNDIR_VARS+="RUNDIR_VOLC_TABLE='\$ROOT/VOLCANO/v2021-09/\$YYYY/\$MM/so2_volcanic_emissions_Carns.\$YYYY\$MM\$DD.rc'\n"

Description of troubleshooting performed

Changed the value of Volcano_Table in HEMCO_Config.rc and the model can proceed.

GEOS-Chem version

7e51a067

Description of modifications

None

Log files

Software versions

yantosca commented 1 year ago

Thanks @kilicomu. We can fix this for GC 14.0.1 as it seems a simple fix.

yantosca commented 1 year ago

This is now fixed in commit 5458939c334cabea9d9490f65fd5a085a81699f6. It will go into GEOS-Chem 14.0.1 (along with other bug fixes), to be released immediately after 14.0.0. I'll close this out now. Thanks for the heads-up @kilicomu!

lizziel commented 1 year ago

If this does not impact the benchmarks can we include it in 14.0.0? It can go into branch feature/minor_rundir_improvements which we haven't merged in yet.

If this bug fix does impact the benchmarks we'll need to hold off until 14.1.0 to include it.

lizziel commented 1 year ago

Looking closer at this I see this is a fix for standard simulation not benchmark. I think we should include it in 14.0.0.

yantosca commented 1 year ago

@lizziel, @Jourdan-He: can I leave it to one of you to implement this?

lizziel commented 1 year ago

I can bring this into 14.0.0 today.