search

geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
163 stars 154 forks source link

[BUG/ISSUE] Non-species restart variables not set in mid-run GCHP checkpoint files #1439

Closed lizziel closed 1 year ago

lizziel commented 1 year ago

What institution are you from?

Harvard University

Description of the problem

Some of the non-species fields in GCHP mid-run checkpoint (restart) files are all zero. This will cause small differences when restarting a run from a mid-point checkpoint file, which can happen if, for example, a long run fails in the middle.

GEOS-Chem version

All GCHP versions.

Description of modifications

The solution is to update the internal state pointers for these fields every timestep rather than just in the first timestep (for use during restart) and the last timestep for outputting the end-of-run file. The area field need only be updated in the first timestep (it is currently only set at the end of the run).

yantosca commented 1 year ago

NOTE: In GCPy 1.3.2, we have a workaround so that the benchmark plotting scripts only look at the surface area in the last restart file. This is good enough to plot the mass tables. A further fix in GCHP is still needed.

lizziel commented 1 year ago

This issue was fixed in 14.0.1, in https://github.com/geoschem/geos-chem/pull/1442. @yantosca, do you mean another fix is needed in GCPy or GCHP?

yantosca commented 1 year ago

All set. I forgot it was fixed in 14.0.1. We can close out this issue then.