geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
171 stars 166 forks source link

[FEATURE REQUEST] Online H2 chemistry from Perez-Peña et al. (2022) #1867

Open msulprizio opened 1 year ago

msulprizio commented 1 year ago

@mpperezp implemented online H2 capability as described in https://acp.copernicus.org/articles/22/12367/2022/acp-22-12367-2022.html.

@jennyfisher wrote:

Maria Paula’s code is here: https://github.com/mpperezp/geos-chem

She forked from a recent version, set it back to the original v12.5, and added all her updates in a single commit in branch called h2_model.

We think most of the changes are in parts of the code that haven’t changed substantially:

  • In HEMCO, addition of a species to GFED inventories (easy update)
  • In KPP, a few small changes to Standard.eqn (moving H2 from fixed to variable and adding it as a product from a few existing reactions)
  • Updates to treatment of H2 in the UCX code, dry dep code, and species_database.

Beyond the code, it’s just some config file updates and input datasets (which Maria Paula can share when needed).

It is not its own specialty simulation but rather an addition to the fullchem simulation. However, it is not strongly affected by any of the rest of the chemistry (e.g. halogens), so shouldn’t need to be re-validated in v14.

@mpperezp also noted:

Part of the development includes the use of H2 dry deposition velocity fields that were provided to me by Hisashi Yashiro (from his work and this information is not yet publicly available. Hisashi Yashiro informs us that he needs to first publish the information on the website of his centre (https://db.cger.nies.go.jp/ged/en/), a process that can take up to 6 months.

jennyfisher commented 1 year ago

We have now been informed by our collaborator Hisashi Yashiro that the H2 deposition database has been released (with DOI) and is available at: https://www.nies.go.jp/doi/10.17595/20230901.001-e.html

When this capability is added to GEOS-Chem, can you make sure to update the GC narrative and new development pages to ensure citation information includes both Pérez-Peña et al. 2022 and the doi-based citation for this dataset that we use?

Thanks!

laura-hyesung-yang commented 11 months ago

@msulprizio Hi Melissa, can I ask which version of GEOS-Chem this new feature would be added to?

msulprizio commented 11 months ago

@laura-hyesung-yang We're wrapping up 14.3.0 now for benchmarking in January, so this won't go in until at least 14.4.0

laura-hyesung-yang commented 11 months ago

@msulprizio Thank you for the update!

msulprizio commented 10 months ago

Hi @laura-hyesung-yang. I am confirming that the Chemistry WG has prioritized this update for 14.4.0 which we aim to release by IGC11 (June 2024).

laura-hyesung-yang commented 10 months ago

@msulprizio Thank you for the update!

laura-hyesung-yang commented 7 months ago

@msulprizio @yantosca Hi Melissa and Bob, I see online H2 chemistry under "Ready to go in" section don't see in wiki page for GCClassic 14.4.0. May I ask if this integration has been cancelled from priority? Thank you!

msulprizio commented 7 months ago

@laura-hyesung-yang Yes, it will be discussed at IGC11 in June.

laura-hyesung-yang commented 7 months ago

@msulprizio Thanks for the update, Melissa! No urgency (currently pursuing a way to treat H2 like CH4) but just wished to check.

jennyfisher commented 7 months ago

FYI neither Maria Paula nor I will be at IGC so please let us know in advance if there are any questions. Laura, you're welcome to check our Maria's code directly if you want to work in an older GC version.

laura-hyesung-yang commented 7 months ago

@jennyfisher Thank you for letting me know! I will keep you updated if I have any questions.