geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
163 stars 154 forks source link

Add ProdLoss diagnostic to aciduptake #2210

Open IshirDutta opened 4 months ago

IshirDutta commented 4 months ago

Name: Ishir Dutta Institution: MIT

Confirm you have reviewed the following documentation

Description of your issue or question

Hi folks,

I've been running v14.3.0 of GEOS-Chem Classic, with a handful of prodloss diagnostics added to my version of custom.kpp (I've also added some dummy variables to track reactions in custom.eqn). Now I've been trying to add some of those same modifications to aciduptake.kpp with one addition of PNITD, but I'm not able to build with ./build_mechanism.sh aciduptake (error attached below).

aciduptake_build.txt

I also noticed that setting up a fresh run directory with aciduptake turned on in ./createRunDir.sh and compiling as normal (without any variation of the -DMECH=custom flag) shows 'fullchem' as the selected KPP version, but allows the aciduptake simulation to run as intended during setup.

Any suggestions are welcome! Thanks!

aciduptake_kpp.txt custom_kpp.txt buildinfo

yantosca commented 4 months ago

Thanks for writing @IshirDutta. The aciduptake KPP mechanism isn't supported (work was started on it by @msl3v) but it was never finished. The aciduptake on dust chemistry is currently handled outside of KPP for now.

Also the aciduptake.kpp file that you've attached is now out of date. Better to start with the custom.kpp file and work from that.