search

geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
167 stars 160 forks source link

OCPISOA and TotalOC not correctly represented in benchmark #2321

Closed yuanjianz closed 2 months ago

yuanjianz commented 3 months ago

Your name

Yuanjian Zhang

Your affiliation

WashU

What happened? What did you expect to happen?

OCPISOA

OCPISOA in benchmark simulation (simpleSOA and complexSOA are both carried) double counts ISOAAQ as was in PM2.5. https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/aerosol_mod.F90#L764-L799 ISOAAQ should be added inside the elseif above to avoid this double-counting.

TotalOC

TotalOC only includes Isoprene SOA OC in complexSOA_nonSVPOA, where both POA and OPOA are not present. https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/diagnostics_mod.F90#L2189-L2200 It should match what is happening in aerosol_mod.F90 https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/aerosol_mod.F90#L502-L511

What are the steps to reproduce the bug?

run a fullchem benchmark simulation

Please attach any relevant configuration and log files.

No response

What GEOS-Chem version were you using?

14.4.0

What environment were you running GEOS-Chem on?

Local cluster

What compiler and version were you using?

gcc 10.2.0

Will you be addressing this bug yourself?

Yes

In what configuration were you running GEOS-Chem?

Other (please explain in additional information section below)

What simulation were you running?

Full chemistry

As what resolution were you running GEOS-Chem?

N/A

What meterology fields did you use?

Other (please explain in additional information section below)

Additional information

No response

yantosca commented 3 months ago

Thanks @yuanjianz for this. Would you be able to prepare a PR for this?

yuanjianz commented 3 months ago

@yantosca Yes, I combine the two OA-related pull requests together. See #2315 .

yantosca commented 2 months ago

Closing this issue as PR #2315 has been merged into the GEOS-Chem 14.5.0 development stream.