geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
164 stars 156 forks source link

Is the 'Photolysis reactions' section of 'Update chemical mechanisms with KPP' out of date? #2378

Closed bethkillen closed 1 month ago

bethkillen commented 1 month ago

Your name

Beth Killen

Your affiliation

UNSW Sydney

Please provide a clear and concise description of your question or discussion topic.

I am a new GEOS-Chem user and I have been trying to add new photolysis reactions into GEOS-Chem. I followed the instructions on the KPP readthedocs and my new reactions were not added to the simulation. According to the KPP page, the parameter JVN_ in the module 'Headers/CMN_FJX_MOD.F90' needs to be updated to match the total number of photolysis reactions. However, since GEOS-Chem now uses CLOUDJ as the default, I believe that the module that needs updating is 'Core/cldJ_cmnmod.F90'. Once I updated JVN in this module, the new reactions were added successfully. Is this the correct procedure? If so, could the KPP instructions be updated to reflect this change?

yantosca commented 1 month ago

Thanks for writing @bethkillen. Yes, that section is out of date. The JVN_ parameter is now found in Cloud-J/src/Core/cldj_cmn_mod.F90. We can update the documentation.

yantosca commented 1 month ago

Hi @bethkillen. I've pushed a fix for the documentations. You can see them at:

bethkillen commented 1 month ago

@yantosca That's great, thank you!