search

geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
170 stars 166 forks source link

Bug fix: allow uppercase log filename in download_data.py #2508

Open ihough opened 1 month ago

ihough commented 1 month ago

Name and Institution (Required)

Name: Ian Hough Institution: Université Grenoble Alpes

Describe the update

Fixes a bug where download_data.py fails if the dryrun log filename contains uppercase characters e.g. 'Log.dryrun'. The solution is to not coerce the dryrun log filename to lowercase.

Expected changes

No changes to model output

Reference(s)

None

Related Github Issue

#70

ihough commented 1 month ago

@yantosca updated the changelog.

yantosca commented 6 days ago

@ihough: Is it OK if I push back to this branch on your fork? That way the updates will show up on the PR. This will also bring in updates from 14.5.0.

ihough commented 6 days ago

@yantosca sure push away!

yantosca commented 6 days ago

Thanks @ihough

yantosca commented 5 days ago

NOTE: I pushed updates before changing the base branch. This PR will close when merged into main.