geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
170 stars 166 forks source link

Bug fixes for the carbon simulations in GCClassic and GCHP #2554

Open msulprizio opened 2 weeks ago

msulprizio commented 2 weeks ago

Name and Institution (Required)

Name: Melissa Sulprizio & Lizzie Lundgren Institution: Harvard University

Describe the update

This pull request contains several fixes and updates to the carbon simulation to (1) reproduce carbon species in the GCClassic standalone CH4, CO2, and tagCO simulations and (2) ensure consistent results between the carbon simulation in GCClassic and GCHP.

Expected changes

These changes impact only the carbon, CH4, CO2, and tagCO simulations and do not impact the full-chemistry benchmark simulations.

Related Github Issue

Aosrain commented 1 week ago

@msulprizio I can successfully compile GCHP 14.5.0, but when I include these bug fixes, the following error appears.

[ 93%] Building Fortran object src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/emissions_mod.F90.o
/nobackup/lwu5/GCHP/src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/emissions_mod.F90(127): error #6580: Name in only-list does not exist or is not accessible.   [EMISS_CARBON_GASES]
    USE Carbon_Gases_Mod,      ONLY : Emiss_Carbon_Gases
--------------------------------------^
compilation aborted for /nobackup/lwu5/GCHP/src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/emissions_mod.F90 (code 1)
make[2]: *** [src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/build.make:283: src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/emissions_mod.F90.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:11451: src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

I found the updated emissions_mod.F90 somewhere, but it doesn't included in the "Files Changed" here. Now the GCClassic is successfully compiled. I'll also try GCHP later.

Aosrain commented 1 day ago

@yidant Would you please upload $ROOT/CH4/v2024-01/ResME/reservoir_mask.01x01.nc to the data server? Thank you.

yidant commented 1 day ago

Thanks @Aosrain! This file is synced!