Closed msulprizio closed 4 years ago
A fix is being tested to address this issue. Hongjian Weng pointed out another issue with the interpolation that will also be addressed here:
For BVOC, Jun and I found a little bug using Yuan LAI. The value of all biogenic VOCs species is zero on the first day and last three days of every year. I think it may because of the time series of Yuan LAI data, which is from 1st day to 361th day.
This has now been resolved in commits 44e157df406945f0b955fdeff83ff93d4310b0e8 and 56f3aab12968c5066a50d496a3412baff8a540b3 and will be included in 12.7.0.
Bob Yantosca discovered an error when using the Yuan-processed MODIS LAI data in GEOS-Chem "Classic" simulations. HEMCO cannot locate the proper bounding timestamps for the interpolation.
Example: HEMCO should have detected that simulation date 20160701 was bounded by data timestamps 20160624 and 20160704, and should have interpolated accordingly. Instead, HEMCO was detecting that simulation data 20160701 was bounded by data timestamps 20160602 and 20160610. This is clearly wrong. Christoph Keller traced this error to routine GET_TIMEIDX in module HEMCO/Core/hcoio_read_std_mod.F90, which is only used for GEOS-Chem "Classic" simulations. The search algorithm was continuing to look for timestamps further back in time than was necessary.
If you need to run GEOS-Chem simulations with the Yuan-processed MODIS LAI data, Christoph Keller has submitted a quick fix. Add the IF statement to this code in hcoio_read_std_mod.F90. This will force the timestamp search algorithm to terminate before it goes too far back in time.
We will try to add a more robust fix for this issue in the near future. We did not want to add a fix that was contingent on a HEMCO container name to the standard code.
NOTE: GCHP is unaffected by this issue, as it uses the MAPL ExtData functionality to read data from disk. We have verified that GCHP reads in the Yuan-processed MODIS LAI data properly.