geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).
http://geos-chem.org
Other
167 stars 160 forks source link

[FEATURE REQUEST] Add complete set of integration tests #714

Open yantosca opened 3 years ago

yantosca commented 3 years ago

The GEOS-Chem integration tests have in general been working well and have allowed us to catch and fix several issues in both GCClassic and GCHP before releasing a new version.

However, some recent "edge cases" (cf https://github.com/geoschem/HEMCO/issues/82, https://github.com/geoschem/HEMCO/issues/84) were not caught by the integration tests and thus required subsequent bug fix commits.

The following additional integration tests would be very useful:

@lizziel, @msulprizio, @yidant: feel free to add to this list

LiamBindle commented 3 years ago

I've ran into an issue a couple times where ExtData.rc was missing an update in HEMCO_Config.rc. If we're putting together a wishlist, I would add something to check that ExtData.rc and HEMCO_Config.rc are in agreement.

Note: I haven't ran into this with official releases, but often I work with developement code and I've ran into it there.

lizziel commented 3 years ago

Looks good. I think once we have zero diffs across single and multi runs we could have a regular test for that too. We aren't there yet though.

@LiamBindle, regarding your request, we've put that on hold pending the update of ExtData.rc and HEMCO_Config.rc to yaml. However, if we find an eager student to put together a script to check the config files as they are now then we should definitely encourage that.

lizziel commented 3 years ago

I just expanded the list to include GCHP RRTMG.

yantosca commented 3 years ago

I've re-enabled the nested-grid integration tests. This was made possible by creating new sample boundary condition files as described in #811.

yantosca commented 1 year ago

Also note: integration tests now use default run directory names in PR #1565

yantosca commented 1 year ago

I've added a GCHP RRTMG integration test as part of #1565.

yantosca commented 1 year ago

@lizziel @msulprizio: Do we still need "DIfference tests for zero-diff updates?" We now have that implmented via the 1-hr cloud benchmarks.

lizziel commented 1 year ago

I added a dry run integration test to the list.