[FEATURE REQUEST] Consolidate Headers/errcode_mod.F90 and GeosUtil/error_mod.F

geoschem / geos-chem

GEOS-Chem "Science Codebase" repository. Contains GEOS-Chem science routines, run directory generation scripts, and interface code. This repository is used as a submodule within the GCClassic and GCHP wrappers, as well as in other modeling contexts (external ESMs).

http://geos-chem.org

Other

162 stars 155 forks source link

[FEATURE REQUEST] Consolidate Headers/errcode_mod.F90 and GeosUtil/error_mod.F #93

Open msulprizio opened 4 years ago

msulprizio commented 4 years ago

Code for error-handling can be found in both

Headers/errcode_mod.F90 : Used to return success or failure by GEOS-Chem routines
GeosUtil/error_mod.F : Contains error-checking routines (e.g. ALLOC_ERROR, GEOS_CHEM_STOP, IS_SAFE_DIV)

Ideally, all error code would be found in one file for clarity.

yantosca commented 4 years ago

One thing I just thought of: ERROR_STOP (in error_mod.F) calls cleanup.F, which is in GeosCore. The cleanup.F code has dependencies for most modules in GeosCore. So if we move this to Headers, we might incur circular dependencies. Something to watch for.