geoschem / integrated_methane_inversion

Integrated Methane Inversion workflow repository.
https://imi.readthedocs.org
MIT License
26 stars 22 forks source link

Unwanted behavior when running IMI modules independently #116

Closed djvaron closed 5 months ago

djvaron commented 1 year ago

Generally we recommend running the IMI in two steps:

(1) create the template run directory and run the preview; (2) run everything else.

However, users may want to run different steps independently, for example to add a custom emission inventory (which requires creating the template run directory, editing HEMCO_Config.rc there, and then running the preview, etc.).

Currently this can lead to some unwanted behavior. I've observed two issues in various testing sessions:

1. Unwanted use of boundary conditions to initialize simulations

Current behavior If the prior/Jacobian/posterior run directories are set up

(a) before the spin-up simulation has been run, AND (b) without setting DoSpinup=true in config.yml,

the IMI will automatically use boundary condition files as restarts for all those simulations.

Desired behavior (?) The IMI should expect to get restarts from a spin-up simulation by default. Users should have to tell it somewhere (presumably in config.yml) to forget the spin-up and initialize from boundary conditions.

Possible fix Rework logic in setup_imi.sh and add a config variable for defining restarts from spin-up vs. boundary conditions.

2. Unwanted start/end dates for simulations after modifying config.yml

Current behavior Example: Set up the template run directory for e.g., a 1-week inversion with start/end dates 20180501/20180508. Then increase the length of the inversion period before running the preview, spin-up, etc. If you do this, the spin-up simulation will get the wrong end date, because it's defined with sed in setup_imi.sh and this will miss 20180508 in the template run directory. The spin-up will then not produce the restart file needed for the other simulations.

Desired behavior (?) The IMI should be able to modify start/end dates regardless of what's contained in the template run directory.

Possible fix Use a Python script like change_dates.py from the feature/kalman-filter branch to modify the geoschem_config.yml file without sed pattern matching.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

github-actions[bot] commented 5 months ago

Closing due to inactivity