search

geoschem / integrated_methane_inversion

Integrated Methane Inversion workflow repository.
https://imi.readthedocs.org
MIT License
26 stars 22 forks source link

bugfix to only turn on extra observation switches for prior and posterior runs #131

Closed sabourbaray closed 1 year ago

sabourbaray commented 1 year ago

Name and Institution (Required)

Name: Sabour Baray Institution: Environment and Climate Change Canada

Describe the update

For the extra observation operators (GOSAT, TCCON, AIRS, Planeflight), currently the IMI switches them on in the template run, which is used to update the geoschem_config.yml files in all run directories. Users will likely only use these comparisons for the base run and posterior run, so we can save computational cost by not running these operators for each jacobian run.

sabourbaray commented 1 year ago

@sabourbaray This is a great idea. Thanks for making the PR. My only comment is that perhaps we should make this a function (eg. activate_observations) that lives in either common.sh or setup.sh. Then call the function in both jacobian.sh and posterior.sh.

Hi Lucas, I've added both of the suggested changes. The function activate_observations is in setup.sh where I think it will be easier to find when setting up the directories.