search

geoschem / integrated_methane_inversion

Integrated Methane Inversion workflow repository.
https://imi.readthedocs.org
MIT License
26 stars 22 forks source link

Statevector defined domain is truncated by buffer zone in nested regions. #134

Open laestrada opened 1 year ago

laestrada commented 1 year ago

Name and Institution (Required)

Name: Lucas Estrada Institution: Harvard ACMG

Description of your issue or question

Name and Institution (Required)

Name: Lucas Estrada Institution: Harvard ACMG

New IMI feature or discussion

Currently GEOS-Chem defines the statevector max/min lat and lon grid centers as the domain edges. But because of the nested domain buffer zone, 3-4 grid cells get chopped off on each side of the domain. This can be misleading for users because the outputted domain is different from the inputted lats/lons.

To fix this issue we should add a function that takes the user-defined statevector and pads it with 3 gridcells (labeled with 0 to prevent additional jacobian simulations). This function should also check whether the buffer-zone gridcells have already been added to the domain to prevent unexpected bloat of the domain when repeatedly running the IMI.

This should not be an issue for most users as long as they are using sufficient large buffer elements surrounding their domain of interest.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

msulprizio commented 5 months ago

@laestrada Is this still an issue?

laestrada commented 5 months ago

@msulprizio I believe this is still an issue