Closed eastjames closed 6 months ago
Hey James, the offset issue you describe was due to an issue in HEMCO that we fixed. See this IMI issue. The solution is to update the HEMCO standalone outputs used for this check using the updated version of HEMCO, which we should probably do before IMI 2.0 anyway given the emissions that have changed recently.
Thanks, Nick. I think this is slightly different -- the latitude adjustment was being applied regardless of what grid resolution is being used, so in global applications it was incorrectly shifting the latitude. I added a check so that it won't apply the adjustment if there is no misalignment. It sounds like updating the HEMCO standalone outputs and getting ride of the latitude adjustment will take care of it, but I needed to do this for now.
Thanks, James - my bad, I just meant that the HEMCO bug was why the adjustment has to exist at all (though it is only applicable for the 0.25° x 0.3125° case as you point out)!
Name and Institution (Required)
Name: James East Institution: Harvard ACMG
Description of your issue or question
I'm using the
feature/global_inversion
branch. When creating a native resolution state vector on the 2x2.5° grid, IMI creates a state vector element for all grid cells north of 60°S, totaling 10,800 state vector elements. A map looks like this:This happens in
src/utilities/make_state_vector_file.py
. The latitude of the HEMCO file used to filter for offshore O&G emissions gets manually adjusted, probably for regional applications. Also, the check for a land threshold always evaluates tofalse
probably not intentionally.Adding a check for mismatched longitudes at line 88-90 and changing the land_threshold check at line 139 seems to work:
New state vector file: