search

geoscixyz / geosci-labs

collection of notebook-apps for concepts in applied geophysics
https://geosci.xyz
MIT License
50 stars 35 forks source link

remove explicit reference to TBL, Lab numbers from notebooks and function names #1

Open lheagy opened 5 years ago

lheagy commented 5 years ago

since these are used in courses beyond EOSC 350 at UBC, the code should not specifically reference "Lab" or "TBL" unless we are explicitly using data from a lab or TBL at UBC

yangdikun commented 5 years ago

Agree. We need apps as general as possible. Another issue to address is not to blend too many things in one notebook - one notebook only conveys one point.

lheagy commented 5 years ago

Specifically, GPR needs to be updated. @dccowan: would you be willing to take an initial crack at this?

@yangdikun: would you be willing to go through the notebooks and see which other ones have language specific to assignments / labs in 350 and list those in this issue so that we can keep track of them?

yangdikun commented 5 years ago

The following contains reference to UBC/TBL/Lab

GPR_Lab6_FitData GPR_TBL4_DOI_Resolution Mag_FitProfile (no specific mentioning of Lab or TBL, but uses magnetic data from UBC)

lheagy commented 5 years ago

Thanks @yangdikun, I think we can update the 2 GPR notebooks fairly easily. The Mag one is a bit tougher - because we do want students to be working with the data they collected.

For this one, I think it is still appropriate to use those data, but we should have the data file be an input parameter to the setup. This way, if you were to run a similar experiment, you could load in your data. Alternatively, you can still use the UBC data. Would that be a suitable solution @yangdikun?

yangdikun commented 5 years ago

The mag data are loaded using like this fileName = 'http://github.com/geoscixyz/gpgLabs/raw/master/assets/Mag/data/Lab1_Wednesday_TA.csv'

Do you think students can replace it with a local data file name (suppose they run the notebooks on bliner)?

Keeping the UBC data is ok because it serves as a template.