search

geoscixyz / geosci-labs

collection of notebook-apps for concepts in applied geophysics
https://geosci.xyz
MIT License
48 stars 33 forks source link

add rms to interval velocity app #40

Closed dccowan closed 2 years ago

dccowan commented 2 years ago

This pull request adds the RMS to interval velocity app to geosci-labs. This app is used in the curvenote project.

jcapriot commented 2 years ago

My guess is it was accidental? I don't think I see anything in the notebooks that changed to make them necessary.

lheagy commented 2 years ago

Okay, then lets remove them prior to merging.

So there are 2 todo items:

@dccowan, would you mind taking a pass at those?

lheagy commented 2 years ago

Thanks for the .gitignore updates @dccowan! It looks like the .npy files are still here. They need to explicitly be deleted and have that deletion be committed to remove them from the pr.

dccowan commented 2 years ago

I reversed the commit, deleted the files, then re-added the changes to the gitignore. Should be good now.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Aug 20, 2021 at 3:51 PM Lindsey Heagy @.***> wrote:

Thanks for the .gitignore updates @dccowan https://github.com/dccowan! It looks like the .npy files are still here. They need to explicitly be deleted and have that deletion be committed to remove them from the pr.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/geoscixyz/geosci-labs/pull/40#issuecomment-902995773, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADC6QGMPISXG55TTEGH2IF3T53L7ZANCNFSM5CMLQQDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Devin C. Cowan (MSc) Software Developer, Research Assistant and Instructor UBC - Geophysical Inversion Facility