Updates Geoscript-py to use latest Geotools

geoscript / geoscript-py

A Python GeoScript Implementation

http://geoscript.net/py

MIT License

52 stars 25 forks source link

Updates Geoscript-py to use latest Geotools #45

Closed dvntucker closed 5 years ago

dvntucker commented 5 years ago

Updates required for Geoscript-py to work with the latest GeoServer/GeoTools.

Removed the explicit dependencies listed in the Ant-run plugin in the pom. These were causing some version discrepancies when trying to run the build.
Update GeoTools class/package names to match GeoTools 21 names.
Update JTS package names.

I tested this with the Geoserver geoscript tests, but wasn't able to run the tests in the project. It looks like the website is down so I couldn't look at the developer guide.

jericks commented 5 years ago

This looks great! Were you able to run the tests?

dvntucker commented 5 years ago

I haven't been able to run the tests yet, I'm going to look into that this morning.

jdeolive commented 5 years ago

@jericks I'll leave it up to you to determine when this is mergable.

dvntucker commented 5 years ago

I'm updating the tests right now. A few issues with them so far but nothing serious.

dvntucker commented 5 years ago

Ok, I was able to run almost all of the tests. I have updated them to work with GeoTools 21+ as well.

I was not able to get the database tests to run. I got to the point where they seemed to be running correctly, but there appear to be some issues with them otherwise. I got past a few of the issues with them, but kept running into more. I think I may be missing something to run them; maybe they need some data loaded first?

jericks commented 5 years ago

These changes look great and are much appreciated! I am not sure how to run the database tests, so when you are happy let me know and I will merge your PR.

Thanks again, Jared

dvntucker commented 5 years ago

Yeah I'm good to merge now!

jdeolive commented 5 years ago

Thanks @dvntucker ! Great stuff.