geoserver / geofence

Advanced Authorization Manager for GeoServer
GNU General Public License v2.0
101 stars 55 forks source link

scroll bar does not display in users or groups list #21

Open aaime opened 10 years ago

aaime commented 10 years ago

Issue by fgravin Monday Nov 25, 2013 at 14:35 GMT Originally opened as https://github.com/geosolutions-it/geofence/issues/83


Hi,

If you have a large number of users or groups, you cannot chose them properly when creating a new rule because the combo box has no scrollbar.

image

I realised that the resources of GXT haven't been upgraded when you updated gxt java version to 2.2.5.

Upgrading resources to 2.2.5 in https://github.com/geosolutions-it/geofence/tree/master/src/gui/web/src/main/resources/it/geosolutions/geofence/gui/public has fixed my issue.

But i have to admit it introduce slight ui bugs (with icons for example) that should be easly fixed.

Cheers

aaime commented 10 years ago

Comment by fgravin Monday Nov 25, 2013 at 14:42 GMT


I can do a PR if you want me to update those resources. But if you want to do it in a specific way (don't import all gxt resources for example) i prefer let you do.

aaime commented 10 years ago

Comment by fgravin Monday Nov 25, 2013 at 16:04 GMT


Updating a css rule in gxt-all.css fixes the icon offset issue after moving to 2.2.5. Add the .x-btn-text-icon .x-btn-icon-small-left .x-btn-text line to this rule :

.x-btn-text-icon .x-btn-icon-small-start .x-btn-text,
.x-btn-text-icon .x-btn-icon-small-left .x-btn-text {
    background-position: 0 center;
    background-repeat: no-repeat;
    padding-left:18px;
    height:16px;
}