geosolutions-it / C179-DBIAIT

DBIAIT project for C179
0 stars 1 forks source link

new update for DBIAIT export #356

Closed mattiagiupponi closed 2 years ago

mattiagiupponi commented 2 years ago

Clients require new changes on the export phase for the following sheets:

Attached the PDF with the instruction provided by the client

20220104 - Integrazioni DBI AIT.pdf

cc: @EddyCatt

mattiagiupponi commented 2 years ago

@EddyCatt is possible ask the following things to the client?

Cap2 Adduttrici:

Cap3 Adduttrici/Distribuzioni e Fognature/Collettori:

Cap7 Fiumi/Laghi/Pozzi/Sorgenti: The table a_acq_capt_conces was excluded only in the Laghi json configuration file, while in the others is already considered (the extraction will take some value and place them in the column requested in the previous development) example: https://github.com/geosolutions-it/C179-DBIAIT/blob/b66ac4bdd3d6f3e842518459f20c93f23f1a6b64/export/config/current/sheet_configs/config_pozzi.json#L188-L198

Cap8 Fognature:

Prevedere il caricamento di un file csv contenente le reti fognarie con stato opera = 6 perché non presenti nel GIS

What this mean? They will provide us a CSV and we need to create the table and the join? They will create the table and we need to change the join to retrieve the value?

mattiagiupponi commented 2 years ago

@EddyCatt I sent you the full report with the changes requested by the client Can you please give a double-check them?

EddyCatt commented 2 years ago

@mattiagiupponi Found issues:

Table Adduttrici ID 117690 Request: In case of blank value, convert to 0 value Issue: Table still has blank values

I have one doubt about the following tables: Table Adduttrici: Only 0 and blank values... Table distribuzioni: empty These two tables are the results of the new filter applied on the new field called "M2-M3a exclusion" to be added in the user_sap table, based on which the records with values in this field must be excluded from the calculation....

mattiagiupponi commented 2 years ago

Table Adduttrici ID 117690 Request: In case of blank value, convert to 0 value Issue: Table still has blank values

As written in the last email from the client, the target value was "volume erogato" with the 117700 ID and not the one in the file. The changes were applied to 117700 and not 117690. Can you confirm this?

I have one doubt about the following tables: Table Adduttrici: Only 0 and blank values... Table distribuzioni: empty These two tables are the results of the new filter applied on the new field called "M2-M3a exclusion" to be added in the user_sap table, based on which the records with values in this field must be excluded from the calculation....

The issue was that the stub data are not updated to the last value available since are meant for testing and they should be immutable. To populate those sheets, I have updated my local stub instance with some extra data. On drive, is available the updated file for a new review -> 832.zip

EddyCatt commented 2 years ago

I sent the zip to the client. Waiting for the review

EddyCatt commented 2 years ago

They've asked to deploy in QAS for testing the modifications