Localized styles not supported for widgets

geosolutions-it / MapStore2-C028

Sistema Informativo Territoriale del Comune di Bolzano

Other

2 stars 8 forks source link

Localized styles not supported for widgets #152

Closed tdipisa closed 4 years ago

tdipisa commented 4 years ago

In dashboards the ENV parameter for localized styles is not currently supported.

The parameter localizedLayerStyles

must be supported in catalog config on DashboardEditor here so that, if set to true, all layers added from the catalog tool in dashboard editor can have the ENV query parameter for each getmap and getlegendgraphic request by default.

Then there must be the possibility to activate/deactivate it per layer inside the layers settings (as it currently is inside the viewer)

tdipisa commented 4 years ago

There is still a problem here (identified on this dashboard in test environment):

as soon as you change language the Use localized styles in layer settings change state (from true to false), therefore the GetMap requests are not including the ENV param:

map_wdg

There is also an issue in legend widget where the Language parameter is not currently supported and the legend for layer quartieri in widget is empty:

MV88 commented 4 years ago

[x] I noticed that the map preview has no localized layers too, so maybe the env paramater is not passed to it.
[x] the problem with reset of the localized styles layer flag when you change locale is because that dashboard had initially set the flag to false, and when changing locale it reloads the dashboard. this does not happen with new dashboards since they have the flag set to true from the start

if you save the dashboard before changing locale it should work

gitcontributor commented 4 years ago

I've fixed bug with LegendPriview in https://github.com/geosolutions-it/MapStore2/pull/5477 Speaking of the 1st problem. I don't think this is a problem because, as Matteo said, changing the locale reloads the page. Only widget changes are saved in the presented gif, but not the dashboard itself, so before the change of locale the dashboard need to be saved.

MV88 commented 4 years ago

@gitcontributor you still need to fix the map preview in the widget wizard

tdipisa commented 4 years ago

@MV88 @gitcontributor ok about the following:

the problem with reset of the localized styles layer flag when you change locale is because that dashboard had initially set the flag to false, and when changing locale it reloads the dashboard. this does not happen with new dashboards since they have the flag set to true from the start

gitcontributor commented 4 years ago

@tdipisa @MV88 I fixed related problems