search

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
486 stars 383 forks source link

Update babel and eslint #10005

Open offtherailz opened 4 months ago

offtherailz commented 4 months ago

Description

A recent PR sent to a project asked to update babel (and so dependent plugins/eslint) to fix a build problem on mac. We should port this Version update on MapStore core.

Trying to do it, we have several errors in eslint (due to old bugs of eslint not revealing some items) alrady notified in the past by @MV88 (see this and this

This issue want to propose an update strategy for it, as easy as possible.

offtherailz commented 4 months ago

(goint to report my findings soon @tdipisa

offtherailz commented 4 months ago

@tdipisa please see my proposed solution here: https://github.com/geosolutions-it/MapStore2/pull/10006

I think it can be reviewed. I preferred to finalize the PR right now that I'm on the problem. As well as my PR is approved by the team I can proceed publishing the eslint config lib on npm and make the build pass.

tdipisa commented 4 months ago

@tdipisa please see my proposed solution here: #10006

I think it can be reviewed. I preferred to finalize the PR right now that I'm on the problem. As well as my PR is approved by the team I can proceed publishing the eslint config lib on npm and make the build pass.

@offtherailz let's discuss briefly before