search

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
505 stars 391 forks source link

Search Plugin - JavaScript console error after first search executed on search bar #10427

Closed ale-cristofori closed 3 months ago

ale-cristofori commented 3 months ago

Description

The Search Service within Maps only seems to work one time before locking up the map. I've included a a screen recording.

The first search works but then nothing after that. Furthermore, the entire map gets locked up after that where I cannot: save the map (if logged in), use the Home button to get back to the main landing page, add new layers from the WMS service or edit layer properties, etc.

How to reproduce

Expected Result The search routine should re-execute and it could be possible to do another address search

Current Result The search plugin does not work anymore, so other plugins and there is a JavaScript console error (see below)

https://github.com/geosolutions-it/MapStore2/assets/14953970/73d9158e-9598-435a-8ce9-590c6c91bef2

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users) | Browser Affected | Version | |---|---| |Internet Explorer| | |Edge| | |Chrome| | |Firefox| | |Safari| |

Other useful information

ale-cristofori commented 3 months ago

@mahmoudadel54 @tdipisa, agreed on 2 hours estimation for investigation

mahmoudadel54 commented 3 months ago

@mahmoudadel54 @tdipisa, client agreed on 2 hours estimation for investigation

@ale-cristofori @tdipisa I have checked it and I found out that it is resolved in this PR: https://github.com/geosolutions-it/MapStore2/pull/10419

tdipisa commented 3 months ago

@ElenaGallo

@ale-cristofori @tdipisa I have checked it and I found out that it is resolved in this PR: #10419

please check it again and confirm.

ElenaGallo commented 3 months ago

@tdipisa @mahmoudadel54 the bug is only present on QA

https://github.com/geosolutions-it/MapStore2/assets/56537133/81c55b74-5f44-45a1-917e-5fcde9283617

tdipisa commented 3 months ago

@ElenaGallo because the backport here still need to be merged https://github.com/geosolutions-it/MapStore2/pull/10435

tdipisa commented 3 months ago

Reviewed and merged now @ElenaGallo please retest once deployed.

ElenaGallo commented 3 months ago

@tdipisa the test also passed on QA