Collapsed icons of widgets change order in Widgets Bar

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!

https://mapstore.geosolutionsgroup.com/

Other

511 stars 398 forks source link

Collapsed icons of widgets change order in Widgets Bar #3549

Closed allyoucanmap closed 4 years ago

allyoucanmap commented 5 years ago

Description

widgets_order

depends on geosolutions-it/MapStore2#3531

In case of Bug (otherwise remove this paragraph)

Browser Affected (use this site: https://www.whatsmybrowser.org/ for non expert users)

[ ] Internet Explorer
[ ] Chrome
[ ] Firefox
[ ] Safari

Browser Version Affected

Steps to reproduce

use following map configuration as new.json
open the map #/viewer/openlayers/new
save the map to geostore and refresh the page
click on expand all widgets button (see GIF in the description)
select the first icon on the right (sheet icon)

Expected Result

sheet icon is still in its position

Current Result

sheet icon shifts on the right

Other useful information (optional):

offtherailz commented 5 years ago

I :

saved the attached txt in new.json
open http://localhost:8081/?#/viewer/openlayers/new
click on expand and then on the first icon

Nothing happened:

i_3549_cannot @allyoucanmap, Is there any other passage I should do? Can you repeat my steps. If you still can reproduce it, can you share the browser and browser version?

allyoucanmap commented 5 years ago

@offtherailz updated steps in description

offtherailz commented 5 years ago

Ok, I found out how to replicate and the cause of this issue:

loading new.json cause a trigger of CHANGE_LAYOUT action, so the widgets.....layout section is updated with current layout (saved in layouts object, that contain one layout for every screen size configured).
Getting the widgets from the map instead do not trigger the CHANGE_LAYOUT, probably because of some difference in mounting/property change sequence due to the network lag, so the initial order does not take into account the current layout, that is not saved in the application state (even if correctly managed by react-grid-layout getting from layouts the right one). Moving one widget or collapsing a widget will trigger CHANGE_LAYOUT, restoring the correct application state.

It should be enough to find out why it is not triggered and fix the issue, or force trigger of CHANGE_LAYOUT.

tdipisa commented 4 years ago

No longer an issue, fixed il latest releases.