geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
511 stars 398 forks source link

Problems applying thumbnail for dashboards #4754

Closed francoxyz closed 4 years ago

francoxyz commented 4 years ago

Description

Applying a thumbnail from homepage for the first time in a dashboard, the following error appears in console: mapstore2.js?59774502c1fb320dd959:1 GET https://qa.mapstore.geo-solutions.it/mapstore/rest/geostore/resources/resource/19341/attributes/thumbnail 404 (Not Found) As soon as i save again the dashboard without thumbnail, the default image gets darker

thumb

How to reproduce

Expected Result 1) No error appears in console 2) The default thumbnail isn't changed

Current Result 1) An error appears in console 2) The default thumbnail is darker than before

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users) | Browser Affected | Version | |---|---| |Internet Explorer| | |Edge| | |Chrome| | |Firefox| | |Safari| |

Other useful information

This Issue is present in DEV, QA and in the RELEASE (test done 21/01/2020)

offtherailz commented 4 years ago

The console error is due to a preventive check of thumbnail existence to clean up, if any), Second time it doesn't happen because the thumbnail attribute extists (or contains NODATA).

so it's ok. It's not an error but a desired behavior (you can not avoid browser logging http errors in console). We can improve it by getting all the attributes (the entry point should always return something ) to avoid a 404, anyway this is an improvement. I'm going to sent a fix for the darken thumbnail

ElenaGallo commented 4 years ago

The console error is due to a preventive check of thumbnail existence to clean up, if any), Second time it doesn't happen because the thumbnail attribute extists (or contains NODATA).

so it's ok. It's not an error but a desired behavior (you can not avoid browser logging http errors in console). We can improve it by getting all the attributes (the entry point should always return something ) to avoid a 404, anyway this is an improvement. I'm going to sent a fix for the darken thumbnail

@tdipisa can I open new issue for this improvement?