search

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
511 stars 398 forks source link

Skip Aggregation on charts #6136

Closed tdipisa closed 3 years ago

tdipisa commented 4 years ago

Description

The spike provided works perfectly. Also filtering by sync map in the dashboard works perfectly. We need also to provide some unit testing and possible fixes on the data retrieve side. It already uses propertyName to get only the attribute involved, without geometries.

Instead on the UI side we have to decide if doing it automatically (if the user do not select the aggregation method) or by explicit selection of a checkbox “do not aggregate”. To verify how having the automatic version influences the performances.

When data is valid, the preview starts getting data, if we want to parse big databases, we may have problems during selection (e.g. select X, Y, want to select group by but it starts downloading a lot of data to generate the preview).

What kind of improvement you want to add? (check one with "x", remove the others)

Other useful information

Actually MapStore supports only chart generation using WPS process “Aggregate”. We can go over this limitation in 2 ways:

This task is independent from the effective chart library we choose. This analysis includes only the option about using WFS.

ElenaGallo commented 3 years ago

@offtherailz If the operation is set to no operation, there are sometimes white lines on the bars of the Bar chart

line

offtherailz commented 3 years ago

Because the values are multiple for each x value (many states for each region, if you don't aggregate you have many "MALE" numbers for each sub-region), They are stacked on the same line, the white lines are the separation between the stacked bars. We could plan to improve styling to make it more evident, and it's more or less the same issue of colors in pie charts reported here https://github.com/geosolutions-it/MapStore2/pull/6163#pullrequestreview-525028583 . We should open a separate issue to improve charts color (as suggested on the same PR discussion).

ElenaGallo commented 3 years ago

@tdipisa can I open a separate issue for the problem explained above?

tdipisa commented 3 years ago

@ElenaGallo yes please, I think it is a low priority now, I will schedule a milestone.