Legend : need a floating panel with full size legend

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!

https://mapstore.geosolutionsgroup.com/

Other

509 stars 394 forks source link

Legend : need a floating panel with full size legend #6779

Open MaelREBOUX opened 3 years ago

MaelREBOUX commented 3 years ago

Description

Currently the legend of the layers are displayed in the TOC.

But depend of kind of styling it is often unreadeable because very too small :

What kind of improvement you want to add? (check one with "x", remove the others)

[x] Minor changes to existing features

I suggest to improve read of the legend by adopting the current way in use in Mviewer :

a_better_legend

landryb commented 3 years ago

seconded, also having a single panel with the legendimages from all the visible layers, like it was in mfapp, is something liked by users !

LouiseBAILLET commented 3 years ago

Agree with this post. It would be very useful and easier to have a floating legend in Mapstore.

catmorales commented 3 years ago

Both proposals are interesting and complementary and go in the direction of a better and quicker understanding of the map, especially as we sometimes have complex legends with many items. If there is a priority to be given, I am leaning towards implementing Maël's request first.

landryb commented 3 years ago

maybe https://mapstore.geo-solutions.it/mapstore/docs/api/plugins#plugins.FloatingLegend is what we need, it's just well hidden somewhere ?

tdipisa commented 3 years ago

maybe https://mapstore.geo-solutions.it/mapstore/docs/api/plugins#plugins.FloatingLegend is what we need, it's just well hidden somewhere ?

@landryb yes, this is more less what you are asking for and it looks similar to the one in description. However, it is a plugin not included in the standard configuration because it is going to be unsupported: no one else has reported any specific interest in it until now.

landryb commented 3 years ago

enabling it locally in my ms2-geor test install, with its default config, here's what it displays:

landryb commented 3 years ago

@tdipisa what's the status of the plugin itself within mapstore ? as you say it's unsupported and i see there are no translations for it, was it an old plugin nobody is maintaining ? or something that can be improved/enabled ? i can do the mapstore PR adding translations...

tdipisa commented 3 years ago

@landryb this is an old plugin that nobody is maintaining at the moment and we have decided to not include it in the default configuration, also because we found the current implementation not so useful: in my opinion it should be reviewed in some way. There is also a pending discussion in the MapStore team to completely remove this tool in favor of other better solutions (to evaluate), but there isn't a final decision on this for now. Feel free anyway to propose your ideas and to contribute on it if you want, let's discuss maybe about this first. For what concerns the geOrchestra issue anyway: I kindly suggest you to clarify about the future of this plugin before enabling it in geOrchestra.

landryb commented 3 years ago

well, i think it has its own usecase, if you want to provide users a way to simply see all layers legends without giving them the fullblown layertree (even if i know, one can disable the sub-plugins/features) - it takes less space than layertree (default group, etc..), and with layertree the layer legends are hidden by default. also, with floatingpanel you only can hide a layer, you cant reorder them - in some cases you might not want users to reorder layers, etc....

but yes, i guess with fine-tuning of layertree, one can more or less get the same feature set. I'll leave the others chime in on this topic :) after all, the original issue was to have a popover (plz, no floating windows!!!) panel with a larger legend.. floatinglegend might allow that via width setting, tested working here.

MaelREBOUX commented 3 years ago

Well. our alpha testers pointed out that access to the legend is so far less usable in MapStore than in Mapfishapp And I can't say they are wrong.

In my point of view we have to discuss quickly on that feature (expand the image legend in a kind of popup; like in mviewer)

landryb commented 2 years ago

Fwiw, on https://mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/7920 i've seen that one can have a widget with the map legend, @tdipisa is this using the deprecated FloatingLegend plugin or should that be the 'right way' of having a floating panel with the legend ?

tdipisa commented 2 years ago

Fwiw, on https://mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/7920 i've seen that one can have a widget with the map legend, @tdipisa is this using the deprecated FloatingLegend plugin or should that be the 'right way' of having a floating panel with the legend ?

@landryb that's simply a quick trick you can do with the current text widget, see below.

legend_widget

landryb commented 2 years ago

Hah, right, nice cheat ;) i thought it was a proper legend panel, but it's just a text widget embedding the getlegendgraphics url so that it refreshes ?

MaelREBOUX commented 2 years ago

What a trick !

But does not resolve entirely the question.