geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
510 stars 398 forks source link

Classification rule UI manager for raster layers #6810

Closed tdipisa closed 3 years ago

tdipisa commented 3 years ago

Description

With the current implementation, the raster symbolizer has a minimum set of functionality compared to vector symbolizers. For vector layers it is currently possible to manage classification rules from the UI by changing values and colors for each rule

The current state of the Raster Symbolizer classification editor

image

Missing components and/or needed improvements:

(1) For raster layers it is possible to classify the style but the same UI to manage classifications rules is not available and need to be included as part of this issue.

Classification entries editor for vector layers

image.png

(2) Along with the above requirement, the uniqueInterval classification method included with #6797 need to be included also for raster styles:

Current methods available for raster symbolizer classification

image.png

What kind of improvement you want to add? (check one with "x", remove the others)

Other useful information

dsuren1 commented 3 years ago

@tdipisa @allyoucanmap Issue 1

Missing components and/or needed improvements:

  • The Contrast enhancement properties selection is incomplete. It see to work only with none inside the classification panel. eg: Normalize allow different algorithm with min and max value see RasterSymbolizer doc. Probably this task needs some updates on the style parsers CSS and SLD

After discussion with @allyoucanmap and some investigation, it looks like the additional algorithms supported by Normalize (StretchToMinimumMaximum, ClipToMinimumMaximum and ClipToZero) mentioned in RasterSymbolizer doc are not supported natively by the geostyler-sld-parser and geostyler-style. Unfortunately there aren't any open issue on Raster symbolizer or customization of normalize contrast enhancement in the geostyler library. So we might need to create a feature request or a issue proposal to geostyler library for the support of customize Normalize Contrast Enhancement. Similiary the enhancement has to be made on geostyler-geocss-parser for css styler

Issue 2

  • Add missing methods: Standard Deviation and Equal Interval (2). We should evalue if they need additional properties and/or if they makes sense for raster classification

Standard Deviation is supported only on vector layers

  • Add classification entries editor similar to vector layers (1)

(1) For raster layers it is possible to classify the style but the same UI to manage classifications rules is not available and need to be included as part of this issue.

(2) Along with the above requirement, the uniqueInterval classification method included with #6797 need to be included also for raster styles:

Classification rules field sample, assuming that it should support custom intervals Raster_classification

Could we split this (#6810) issue into two, one to separately investigate and decide on the external & internal library improvement to support algorithms and one to enhance to the raster classification styling?

tdipisa commented 3 years ago

@dsuren1 you can split the issue as you suggested in the above comment. Summarizing, if I understood correclty, we have:

dsuren1 commented 3 years ago

Note: This issue will handle the enhancement to the raster classification styling

tdipisa commented 3 years ago

Note: This issue will handle the enhancement to the raster classification styling

@dsuren1 just to be clear, this point:

One issue for the support of Normalize a algorithms that should be included in

is covered by #6933 right?

dsuren1 commented 3 years ago

Yes, that's right @tdipisa