Closed tdipisa closed 3 years ago
Needed as part of this issue
Needs to be estimated
Nice to have
@dsuren1 let's have a quick call for these points so that you can do the requested evaluation:
- Ability to customize marker (Like annotation - UI to select marker style)
- Arrow on descriptive panel (Include swipe for mobile)
@dsuren1 I've created a new dedicate issue for the estimate of the point below
- Ability to customize marker (Like annotation - UI to select marker style)
You can open an issue for the other point, that is already clear to you, and do the estimate there.
- Arrow on descriptive panel (Include swipe for mobile)
@dsuren1 @tdipisa here some notes on the Goecarousel section:
1_ By adding a new item, the geostory scrolls down
How to Reproduce
Current Result Adding a new item moves the section
2_ From View Mode, by selecting a GeoCarousel section from the navigation bar, you are not shown on the corresponding section
How to Reproduce
Current Result the geostory does not bring you back to the selected section
3_ From the sharing map, the markers are not present on the map
How to Reproduce
Current Result The markers are not present on the map
4_ From the embedded map, clicking the marker on the map displays the gray error page
How to Reproduce
Current Result The gray error page appears
5_ From mobile, clicking the marker on the map displays the gray error page
How to Reproduce
Current Result The gray error page appears
@dsuren1 I found another problem in the embedded geostory:
How to Reproduce
Expected Result
Current Result
Gostory link here
@dsuren1 I found another problem in the embedded geostory:
- The layer present in the background map, on GeoCarousel section, is not visible.
How to Reproduce
- Open the embedded geostory
Expected Result
Current Result
Gostory link here
I believe it has something to do with layer/style permission as geostory-embedded needs shared/accessible resource to work with. As you can see here https://dev-mapstore.geosolutionsgroup.com/mapstore/geostory-embedded.html#/35120, https://dev-mapstore.geosolutionsgroup.com/mapstore/geostory-embedded.html#/34844, these geostory displays layers properly, as it uses layer from _gs:usstates & _topp:statestest which are accessible. Note: Also you can see this behavior with existing sections as well, so I'm pretty sure this is not an issue and especially not an issue with carousel section. Hope it helps!
@ElenaGallo, that's true.
I believe it has something to do with layer/style permission as geostory-embedded needs shared/accessible resource to work with. As you can see here https://dev-mapstore.geosolutionsgroup.com/mapstore/geostory-embedded.html#/35120, https://dev-mapstore.geosolutionsgroup.com/mapstore/geostory-embedded.html#/34844, these geostory displays layers properly, as it uses layer from gs:us_states & topp:states_test which are accessible. Note: Also you can see this behavior with existing sections as well, so I'm pretty sure this is not an issue and especially not an issue with carousel section. Hope it helps!
@dsuren1 @allyoucanmap
[ ] On the embedded geostory and on mobile, the title popoup cover the marker. See this enbedded geostory
[ ] The carousel map has a different bbox after it is saved with the marker
How to reproduce Follow the gif below:
@ElenaGallo
On the embedded geostory and on mobile, the title popoup cover the marker. See this enbedded geostory
Please open a new issue for this with Internal label
The carousel map has a different bbox after it is saved with the marker
This is a fetaure not a bug, the map is always zoomed to the selected marker.
Closed in favor of #7143
Description
A new type of section for GeoStory will be available: the GeoCarousel section. The aim of this new section is to enhance the user experience in using geostories by adding a different kind of section to browse map locations with an accompanying descriptive content.
A GeoCarousel section is a full screen section, like the immersive one currently available, that allows the story editor to define a list of items to be presented with a accompanying descriptive content (using text, media etc) and a geographic location.
Acceptance criteria
When the GeoCarousel section is added to the story (the user clicks on the related button in the above toolbar), the story will scroll to the new section that will cover the entire screen (as it is now for immersive sections)
In edit mode the GeoCarousel section will be composed by: a background with its editing toolbar, a descriptive (narrative) panel on top with its editing toolbar (the same column component of the immersive section), a carousel just below the background to list/manage items to be associated with a position in the map. The view mode will be basically the same but without editing toolbars
Descriptive panel: it is the same component available in immersive section but, for this section a fixed height must be set for this panel so that the scrollbar appears at a certain point: the GeoCarousel section is not expected to have a variable height like for Immersive sections. We have to set a proper height and make the Descriptive panel responsive depending on the screen.
In viewing mode the GeoCarouser and all editing controls (such as toolbars) disappear as usual and it is possible to browse the carousel items by scrolling with the mouse in the carousel section or using left/right arrows
In edit mode the GeoCarousel will allow to manage the following:
Two buttons on the left side of the GeoCarousel will allow to:
Below are two proposals for the two buttons in the UI:
For each item in the carousel a small toolbar allows the story editor to control actions like:
It is possible to drag&drop items in the carousel to change their order in the list
Selecting a card item in the carousel (bot view and edit mode) the map can move/zoom to the related marker as specified above but also the descriptive panel changes accordingly by showing the content configured for the selected carousel item
As usual also for all the other sections types, a plus button in the mid-bottom side of the slideshow section allows to add other sections
Other useful information
The responsivnes should be taken into account and better evaluated for mobile devices. The presentation could be the same of an immersive section. Users can tap on the descriptive panel to zoom the map to the marker and it is also possible to: