Vector Layers Style Review

[tdipisa]

Description

The current styler for vector layers (for both 2D and 3D maps) should be review to be inline with the recent evolutions made so far for the Visual Style Editor and 3D Tiles styler: UI design and underlying logic. This work involve both WFS and imported vector layers but not Annotations for which the logic is different (this will be part of a future work).

As for labeling the styling needs to be separated in two different categories:

• Styling for 3D tiles: already done with #8010
• Styling for vector data (3d lines or 3d points)

Vector data styling for cesium referring to 3d lines and points will need a different encoding so as part of the issue we need to:

• Evaluate the additional style properties that could be supported by vector data in cesium
• Perform an analysis of what needs to be done to extend annotations to work in 3D and we will try to implement basic support for point based annotations with labels and marks.

What kind of improvement you want to add? (check one with "x", remove the others)

• [ ] Minor changes to existing features
• [ ] Code style update (formatting, local variables)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] CI related changes
• [X] Other... Please describe: vector layer styling logic review for 3D

Other useful information

[allyoucanmap]

Cesium Styling

The base support of style should cover these improvements:

• [x] conversion of current style to the geostyler json structure. Limitation of styling applying per features where only the features with properties.id will be taken into account (eg annotation)
• [x] support of Mark, Icon, Line, Fill symbolizers with filtering option based on the attributes available

Current limitations:

• It's possible to apply only one type of symbolizer at the time so it the rule editor shows multiple rule with the same filter only the first one is used. This is due to the rendering behaviour of cesium/leaflet where on a entity (geometry) is only possible to apply a type of symbolizer. #8302
• Line: line cap and join are not available as properties in Cesium PolylineGraphic #8301
• Conversion from legacy style does not support geometry transformations because are missing as concept in the geostyler spec and there could be limitation in the cesium style itself (eg start/end point of a line in annotation). We could extend the geostyler spec and investigate on a possible approach #8299

Additional interesting properties that could be added to UI but available only for Cesium. This task will need also an extension of the geostyler spec (at some point we will need a fork for this): #8298

• [ ] To investigate Mark, Icon: use BillboardGraphics

  • pixelOffset Property specifying the pixel offset.
  • eyeOffset Property specifying the eye offset.
  • horizontalOrigin
  • verticalOrigin
  • alignedAxis A Cartesian3 Property specifying the unit vector axis of rotation.
  • height A numeric Property specifying the height of the billboard in pixels, overriding the native size.
  • disableDepthTestDistance A Property specifying the distance from the camera at which to disable the depth test to.

• [ ] To investigate Line: use PolylineGraphics

  • arcType specifying whether the line segments should be great arcs, rhumb lines or linearly connected.. default GEODESIC
  • clampToGround specifying whether the polyline should be clamped to the ground.

• [ ] To investigate Fill: use PolygonGraphics

  • height constant altitude of the polygon.
  • extrudedHeight altitude of the polygon extrusion
  • arcType type of lines the polygon edges use. default GEODESIC

• [ ] To investigate Inclusion of fill pattern style (it's possible to apply custom material)

Screenshot

Mark:

Icon:

Line:

Fill:

Conversion legacy style to current for annotation:

OpenLayers

Cesium

UI/Component Improvements Proposal

• [ ] Remove the legacy styling from Leaflet feature (TBD, it would be nice also for OpenLayers) #8303
• [ ] Visual Style Editor: Remove slider from symbolizer property that need a more granular value selection an use a number input: radius, size #8300
  • [ ] Visual Style Editor: Classification rule client side. WFS could use a similar workflow we had for WMS layers using the sldservice while for vector layer we could use some client library such as d3-scale to compute classification. Alternatively we could implement WFS layer classification in a similar way we implement vector and use geoserver to request only information about feature type #8304
  • [ ] WFS/Vector layer legend: component able to render a legend client side based on the styles rules #8306

[ElenaGallo]

Hi @allyoucanmap here what I found after testing this map on 3D mode:

1) For Point layer (ex: V_INTERVENTI), when you change the color of the halo, the width of the halo and the rotation, in the Text rule, the changes are not visible on the map

2) For polygonal and linear layers (ex: V_PIANO_BACINO, PROT.CIV: RIVI and TORRENTI MINORI), the Mark, Icon, Line and Text rules are not visible on the map

https://user-images.githubusercontent.com/56537133/170230638-8a48850f-c39d-4373-8a2a-0793b03266de.mov

Possible Component Improvements

a) In in Cesium, the widget button is available for layers but then the widgets are not visible in the viewer b) In the attribute table: Zoom to feature does not zoom correctly on the feature and the Filter clicking on the map does not work. c) The Filter layer with Area of Interest does not work (it is not possible to draw a rectangle, circle, etc. on the map)

[allyoucanmap]

@tdipisa @ElenaGallo

1) For Point layer (ex: V_INTERVENTI), when you change the color of the halo, the width of the halo and the rotation, in the Text rule, the changes are not visible on the map

If you agree I'll move this fix to the issue related to labels (https://github.com/geosolutions-it/MapStore2/issues/8102) so we can verify how this could be improved. The PR associated to this issue has only introduced a base support of label symbolizer.

2) For polygonal and linear layers (ex: V_PIANO_BACINO, PROT.CIV: RIVI and TORRENTI MINORI), the Mark, Icon, Line and Text rules are not visible on the map

The style editor is enabling the style symbolizers based on the geometry type returned by the DescribeFeatureType request and in this specific case is defined as Geometry without specifying if it's a point, line or polygon. It the geometry is generic all the symbolizers are enabled and they will be applied only to the matching geometry:

• fill -> polygon
• line -> line
• icon -> point
• mark -> point
• label -> point

so in this situation is not possible to apply an icon to polygon. We could try to support symbolizers to not matching geometry but this will need some geometry transformation, for example get the centroid of the polygon to apply an icon. In my opinion this need a separated task

eg V_PIANO_BACINO response

[tdipisa]

@allyoucanmap

If you agree I'll move this fix to the issue related to labels (https://github.com/geosolutions-it/MapStore2/issues/8102) so we can verify how this could be improved. The PR associated to this issue has only introduced a base support of label symbolizer.

The issue you are referring to is related to 3D Tiles labeling while here we are talking about vector layers.

so in this situation is not possible to apply an icon to polygon. We could try to support symbolizers to not matching geometry but this will need some geometry transformation, for example get the centroid of the polygon to apply an icon. In my opinion this need a separated task

Make sense. @allyoucanmap can you open a dedicate issue for this and assign it to me? I will take care of scheduling it when possible.

@ElenaGallo please open dedicated issues for the following points (use the label 3D) and assign all of them to me:

a) In in Cesium, the widget button is available for layers but then the widgets are not visible in the viewer

b) In the attribute table: the Filter clicking on the map does not work

c) The Filter layer with Area of Interest does not work (it is not possible to draw a rectangle, circle, etc. on the map)

[allyoucanmap]

The issue you are referring to is related to 3D Tiles labeling while here we are talking about vector layers.

updated issue including also labels investigation/improvement for vector/WFS https://github.com/geosolutions-it/MapStore2/issues/8102

[allyoucanmap]

Make sense. @allyoucanmap can you open a dedicate issue for this and assign it to me? I will take care of scheduling it when possible.

@tdipisa https://github.com/geosolutions-it/MapStore2/issues/8264