Error sharing as iframe GeoStory or Dashboar

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!

https://mapstore.geosolutionsgroup.com/

Other

513 stars 400 forks source link

Error sharing as iframe GeoStory or Dashboar #8478

Closed ElenaGallo closed 2 years ago

ElenaGallo commented 2 years ago

Description

It is not possible to share as iframe a geostroy or dashboard

How to reproduce

Login as admin
Open a geostory/dashboard
Click on Share
Click on Embed
Copy the iframe
Past on a new html page (en example here: dash.zip)

Expected Result

It is possible to see the embed dashboard or geostory

[x] Not browser related

Browser info

(use this site: https://www.whatsmybrowser.org/ for non expert users) | Browser Affected | Version | |---|---| |Internet Explorer| | |Edge| | |Chrome| | |Firefox| | |Safari| |

Other useful information

It seems a regression introduced after #8457. The tool works well in QA.

tdipisa commented 2 years ago

@alexander-fedorenko I see this issue is connected to #8503 now testable in DEV since #8495 is now merged. It seems anyway a server side issue where embeddigng through iframe is not allowed at the moment for some reason and not something connected to the modular plugin work. Therefore, I'm wondering what you have fixed for this.

alexander-fedorenko commented 2 years ago

@tdipisa Initial issue was that dashboard and geostory was not rendered in iframe at all, there was a white blank page instead of the content. This issue is seems to be a different one and it also is not getting reproduced locally with default proxy configuration.

tdipisa commented 2 years ago

This issue is seems to be a different one and it also is not getting reproduced locally with default proxy configuration.

This is quite strange I think.

In QA the problem is not present anyway, just checked.

tdipisa commented 2 years ago

@lpasquali

@alexander-fedorenko I see this issue is connected to #8503 now testable in DEV since #8495 is now merged. It seems anyway a server side issue where embeddigng through iframe is not allowed at the moment for some reason and not something connected to the modular plugin work. Therefore, I'm wondering what you have fixed for this.

@lpasquali can you please check DEV config please? Last time @randomorder fixed the embedding with iframe via HTTP POST for DEV but via HTTP GET it was working. Maybe he broke something for GET?

In QA we have:

POST not working GET working

It would be good to fix also QA possibly

lpasquali commented 2 years ago

@tdipisa could you try now?

tdipisa commented 2 years ago

@lpasquali the behavior is the same as before.

ElenaGallo commented 2 years ago

@tdipisa

@alexander-fedorenko I see this issue is connected to #8503 now testable in DEV since #8495 is now merged. It seems anyway a server side issue where embeddigng through iframe is not allowed at the moment for some reason and not something connected to the modular plugin work. Therefore, I'm wondering what you have fixed for this.

this error is still present on DEV

tdipisa commented 2 years ago

@ElenaGallo there is currently an issue in our webserver (@lpasquali knows about this) that is preventing the embedding via Iframe from localhost. If you test this functionality from an online domain like our demo site, it is working well. I will raise a separate issue to ask devops to make it working again from localhost for development purposes.