search

geosolutions-it / MapStore2

The solution to create and share maps, dashboards, geostories with 3D support on the web. And it is open-source too!
https://mapstore.geosolutionsgroup.com/
Other
512 stars 399 forks source link

3DTiles display issue #8843

Closed CRAIGKP63 closed 1 year ago

CRAIGKP63 commented 1 year ago

Description

Buildings exported in 3DTiles do not display on Mapstore with cesium version while they display correctly on the Cesium Ion version. 3DTiles support remains imperfect.

How to reproduce

Expected Result

Current Result

cesium_ion

No data is displayed on mapstore with the same 3DTile while without textures it works.

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users) | Browser Affected | Version | |---|---| |Internet Explorer| | |Edge| | |Chrome| | |Firefox| | |Safari| |

Other useful information

landryb commented 1 year ago

more details: the tileset on cesium ion is at https://assets.cesium.com/1416735/tileset.json but as is without proper CORS config it cant be loaded in mapstore due to proxy/CORS issues.

I've put a copy of the tileset in https://3d.craig.fr/datasets/Montlucon/bug_textures/tileset.json - as is it wont load in https://georchestra.geo-solutions.it/mapstore/ because it seems the cors proxy is broken on the demo site (only returns 500 codes) but you can try loading it in https://ids.craig.fr/mapstore/#/ (running 2022.01) which has CORS properly configured.

You can see a GET done on:

you can recenter/zoom in on the dataset, but no other request is done on the b3dm files, and nothing is displayed in mapstore. The cesium ion example url manages to load that dataset fine as seen on the screenshot above.

any idea @allyoucanmap ?

tdipisa commented 1 year ago

@landryb @CRAIGKP63 we will do a check. Thank you for reporting.

allyoucanmap commented 1 year ago

@tdipisa @landryb @CRAIGKP63 This issue seems related to the missing third party draco decoder fixed with this PR https://github.com/geosolutions-it/MapStore2/pull/8204

image

This fix has been backported on the official 2022.01.xx branch with this other PR https://github.com/geosolutions-it/MapStore2/pull/8244.

We tested the same tilesets on a MapStore version 2022.01.xx and 2022.02.xx and they are working as expected:

2022.01.xx image

2022.02.xx image

Note: I was not able to test the https://3d.craig.fr/datasets/Montlucon/bug_textures/Buildings/tileset.json endpoint because is returning a 404 error

allyoucanmap commented 1 year ago

Closing because has been solved with this issue #8202

landryb commented 1 year ago

thanks a lot @allyoucanmap, i'll try to update our mapstore to a version including #8202. The version we use in production was rebased somewhere around may, so i dont think we have that PR - per https://github.com/landryb/MapStore2/commits/2022.01.xx-georchestra-craig and #8202 was only backported in that branch via #8244

CRAIGKP63 commented 1 year ago

Thank you very much @allyoucanmap! Data works fine on the latest version of Mapstore