geosolutions-it / ckanext-dcatapit

CKAN extension for the Italian Open Data Portals (DCAT_AP-IT)
GNU Affero General Public License v3.0
10 stars 18 forks source link

Restore help tooltips #284

Open etj opened 2 years ago

etj commented 2 years ago

When editing a dataset, there's a space between every upper input and the lower label image

that is a badly rendered <span> info tooltip:

image

By replacing the proper fa fa-info-circle in place of the old icon-info-sign I get this: image

etj commented 2 years ago

Macro help_block --> https://github.com/geosolutions-it/ckanext-dcatapit/blob/1292090c0c222415cc5e0ad14a2d370c2a3f29fc/ckanext/dcatapit/templates/macros/dcatapit_form_macros.html#L473-L479

The macro is only called within the same file.

Related js should be at https://github.com/geosolutions-it/ckanext-dcatapit/blob/1292090c0c222415cc5e0ad14a2d370c2a3f29fc/ckanext/dcatapit/fanstatic/dcatapit.js#L577-L587

etj commented 2 years ago

I guess that most of the macro code has been taken from an older version of CKAN.
See https://github.com/ckan/ckan/blob/ckan-2.9.5/ckan/templates/macros/form.html#L338-L345