search

geosolutions-it / ckanext-dcatapit

CKAN extension for the Italian Open Data Portals (DCAT_AP-IT)
GNU Affero General Public License v3.0
11 stars 18 forks source link

Investigate in creator being handled out of scope #290

Open etj opened 2 years ago

etj commented 2 years ago

creator fields are handled in an _alternate_id method that should not be intended to manipulate them

https://github.com/geosolutions-it/ckanext-dcatapit/blob/c8edf370d7f226703d5d59e8b9703ffa12fb9959/ckanext/dcatapit/dcat/profiles.py#L521-L541

Move the creator logic where it belong.

etj commented 2 years ago

The method is looking for a DCT.creator in the alternate identifier node.

Current dcatapit doc does not mention it.

Anyway adms:Identifier definition does refer to creator:

 <http://www.w3.org/ns/adms#Identifier> dcterms:identifier "adms:Identifier";
    a rdfs:Class;
    rdfs:comment "This class is based on the UN/CEFACT Identifier complex type defined in See Section 5.8 of Core Components Data Type Catalogue Version 3.1 (http://www.unece.org/fileadmin/DAM/cefact/codesfortrade/CCTS/CCTS-DTCatalogueVersion3p1.pdf) In RDF this is expressed using the following properties: 
           - the content string should be provided using skos:notation, datatyped with the identifier scheme (inclduing the version number if appropriate); 
           - use dcterms:creator to link to a class describing the agency that manages the identifier scheme or adms:schemaAgency to provide the name as a literal. Although not part of the ADMS conceptual model, it may be useful to provide further properties to the Identifier class such as dcterms:created to provide the date on which the identifier was issued."^^rdf:XMLLiteral;
    rdfs:isDefinedBy <http://www.w3.org/TR/vocab-adms>;
    rdfs:label "Identifier"@en.

but its use is not enforced nor recommended nor suggested by AgID.

Remove that code at next cleanup.