search

geosolutions-it / fra2015

FRA2015 survey
0 stars 5 forks source link

NPE tiers validator #325

Closed Damianofds closed 10 years ago

Damianofds commented 10 years ago

This error has been find in the logs when testing.

Note that otherwise this exception the workflow seems work well

ERROR 2013-10-28 00:17:22.539 it.geosolutions.fra2015.mvc.validation.TiersValidator::checkTiers:83 -
java.lang.NullPointerException
        at it.geosolutions.fra2015.mvc.validation.TiersValidator$TierRowName.<init>(TiersValidator.java:126)
        at it.geosolutions.fra2015.mvc.validation.TiersValidator.checkTiers(TiersValidator.java:74)
        at it.geosolutions.fra2015.mvc.controller.CheckController.printWelcome(CheckController.java:98)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:176)
        at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:427)
        at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:415)
        at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:788)
        at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:717)
        at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
        at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:549)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:366)
        at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:109)
        at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:83)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:97)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:100)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:78)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:54)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:35)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:177)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:187)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:105)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:79)
        at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
        at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:167)
        at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237)
        at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
        at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
        at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
        at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:776)
        at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:705)
        at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:898)
        at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
        at java.lang.Thread.run(Thread.java:662)
INFO  2013-10-28 00:17:33.415 it.geosolutions.fra2015.mvc.controller.CheckController::printWelcome:187 - submitted survey:DZA
INFO  2013-10-28 00:17:33.433 it.geosolutions.fra2015.mvc.controller.CheckController::printWelcome:191 - ----------------- state transition: WORKINPROGRESS-COMPLILED --------------------
INFO  2013-10-28 00:17:33.434 it.geosolutions.fra2015.mvc.controller.CheckController::printWelcome:192 - ----------------- Selected Users (Reviewers) to notify with Mail: ---------------
INFO  2013-10-28 00:17:33.435 it.geosolutions.fra2015.mvc.controller.CheckController::printWelcome:193 - UserNames List: ['Monica','rev','dzarev1',]
INFO  2013-10-28 00:17:33.435 it.geosolutions.fra2015.mvc.controller.CheckController::printWelcome:194 - ----------------------------------------------------------------------------------
INFO  2013-10-28 00:17:36.665 it.geosolutions.fra2015.services.mail.NotificationSerivice::sendMessage:238 - Mail sent FROM fra2015.notifier@gmail.com TO Monica.Garzuglia@fao.org USING org.springframework.mail.javamail.JavaMailSenderImpl@2e3aca36
INFO  2013-10-28 00:17:38.585 it.geosolutions.fra2015.services.mail.NotificationSerivice::sendMessage:238 - Mail sent FROM fra2015.notifier@gmail.com TO rev@r.n USING org.springframework.mail.javamail.JavaMailSenderImpl@2e3aca36
INFO  2013-10-28 00:17:40.320 it.geosolutions.fra2015.services.mail.NotificationSerivice::sendMessage:238 - Mail sent FROM fra2015.notifier@gmail.com TO dzarev1@f.c USING org.springframework.mail.javamail.JavaMailSenderImpl@2e3aca36
INFO  2013-10-28 00:19:07.676 it.geosolutions.fra2015.mvc.concurrency.SessionListener::sessionDestroyed:53 - User dza1: Session Destroyed...
Damianofds commented 10 years ago

can't try to replicate the issue...

etj commented 10 years ago

Can't replicate. Closing.

Damianofds commented 10 years ago

found this stack trace on the fra2015 log http://pastebin.com/GhQ4510f

Damianofds commented 10 years ago

Maybe a dump from fra2015 is needed: some entry item could be not correctly updated (the rowname field) when the new check tiers features has been deployed.... The error should be that there is/are a/some entry item without rowName

etj commented 10 years ago

Log has been improved: check first line:

WARN  2013-11-26 13:14:09.411 it.geosolutions.fra2015.mvc.validation.TiersValidator::checkTiers:75 - Null name for tier EntryItem{id=215123, row#1, col#2, entry=Entry{var=136, type=table, q=Question{16}, parent=}, rowN=null, colN=null, type=String}
ERROR 2013-11-26 13:14:09.413 it.geosolutions.fra2015.mvc.validation.TiersValidator::checkTiers:86 - 
java.lang.NullPointerException
    at it.geosolutions.fra2015.mvc.validation.TiersValidator$TierRowName.<init>(TiersValidator.java:129)
    at it.geosolutions.fra2015.mvc.validation.TiersValidator.checkTiers(TiersValidator.java:77)
    at it.geosolutions.fra2015.mvc.controller.CheckController.printWelcome(CheckController.java:98)
etj commented 10 years ago

There are some illegal entries for tiers variables imported using the XML importer.