Closed Damianofds closed 11 years ago
You should always squash the commits inside a pull request to a single commit to ease reviewers' work
Looks good to me
Merge ahead then :)
Regards,
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
Ing. Simone Giannecchini @simogeo Founder/Director
GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928
http://www.geo-solutions.it http://twitter.com/geosolutions_it
On Wed, Sep 4, 2013 at 9:40 AM, mbarto notifications@github.com wrote:
Looks good to me
— Reply to this email directly or view it on GitHubhttps://github.com/geosolutions-it/geobatch/pull/221#issuecomment-23771329 .
This improvement allow to perform a reprojection from the SourceFeature to OutputFeature when a DS2DS is performed.
The changes are:
All DS2DS tests still works on Eclipse and a compilation with mvn clean install -o -Dall has been succesfully performed. The action has been tested on tomcat performing an ingestion of several shapefiles in 3 differents CRS and reprojected in EPSG:4326. Everything seems works.