Add embed template for geostory app

geosolutions-it / geonode-mapstore-client

MapStore Client for GeoNode

Other

2 stars 131 forks source link

Add embed template for geostory app #198

Closed allyoucanmap closed 3 years ago

allyoucanmap commented 4 years ago

We should add the template for the geostory pages similar to maps to display geostory full page without the navbar. The server is providing the path apps/{pk}/embed but the app_embed.html is not implemented in the client.

allyoucanmap commented 4 years ago

cc: @simboss

giohappy commented 4 years ago

yes, this is probably also needed for a feature requested by MapStand. Let's wait a green light from them and @simboss on this.

simboss commented 4 years ago

@giohappy @allyoucanmap estimate?

simboss commented 4 years ago

I'd say let's go ahead.

This would be useful for other clients as well.

allyoucanmap commented 4 years ago

@giohappy @allyoucanmap estimate?

it should be ~ 1day

simboss commented 4 years ago

I'd go ahead and do this asap.

Please, coordinate with @giohappy as I do not want to step on his toes.

allyoucanmap commented 4 years ago

@simboss @giohappy we just merged the code with the improvement about the embed. We added also a simplified share panel to access to the embed link. You can try this on the dev instance https://dev.geonode.geo-solutions.it/apps

cc @afabiani

giohappy commented 4 years ago

I suggest to add the same functionality to GN maps now...

simboss commented 4 years ago

I agree with @giohappy.

allyoucanmap commented 4 years ago

@giohappy @simboss added share panel in maps pages pointing to the the maps/{id}/embed page (https://dev.geonode.geo-solutions.it/maps)

simboss commented 4 years ago

great