geosolutions-it / geonode-project

A django template project for creating custom GeoNode projects.
http://geonode.org
0 stars 5 forks source link

Upgrade docker compose version #34

Closed bieganowski closed 2 years ago

giohappy commented 3 years ago

no syntax changes between the two versions @bieganowski?

afabiani commented 3 years ago

I would compare and update the docke-compose.yml with the GeoNode master one.

Make sure to update it accordingly to the {{project_name}} template.

giohappy commented 3 years ago

@afabiani are you sure? The two are not only different in version and syntax but also between services definitions. For example geoserver image is built from the local docker definitions in geonode-projecg, while geonode uses the docker hub image.

What do you mean by using the one from geonode?

afabiani commented 3 years ago

I mean, re-using the same approach and concept from docker compose 3.4

bieganowski commented 3 years ago

@giohappy https://docs.docker.com/compose/compose-file/compose-versioning/#version-2x-to-3x

bieganowski commented 3 years ago

@afabiani, @giohappy docker-compose file is updated in accordance to Geonode's master one. I conducted some simple tests (including creating a project based on this geonode-project's branch, setting up the environment with docker-compose, and loading a layer) and everything works fine, but it would be great, if you could take some time to check if there are no mistakes there.

From changes which might be interesting

afabiani commented 3 years ago

looks good