geosolutions-it / http-proxy

Lean and Mean HTTP Proxy written in Java
GNU General Public License v3.0
21 stars 31 forks source link

Explicitly configure used versions of build plugins #40

Closed marcjansen closed 8 years ago

marcjansen commented 8 years ago

I don't know if you intentionally leave out the <version> of most of the build plugins, but it leads to these warnings when building via maven:

[WARNING] Some problems were encountered while building the effective model for proxy:http_proxy:war:1.1-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 28, column 12

etc.

I can come up with a PR changing this as follows, if you are interested:

diff --git a/pom.xml b/pom.xml
index 6d8fb34..fafc019 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,6 +27,7 @@
                <plugins>
                        <plugin>
                                <artifactId>maven-compiler-plugin</artifactId>
+                               <version>3.5.1</version>
                                <configuration>
                                        <source>1.6</source>
                                        <target>1.6</target>
@@ -36,6 +37,7 @@
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-surefire-plugin</artifactId>
+                               <version>2.19.1</version>
                                <configuration>
                                        <skip>false</skip>
                                </configuration>
@@ -44,6 +46,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <version>2.6</version>
                 <executions>
                     <execution>
                         <id>make-a-jar</id>
@@ -58,6 +61,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-install-plugin</artifactId>
+                <version>2.5.2</version>
                 <executions>
                     <execution>
                         <phase>install</phase>
@@ -78,6 +82,7 @@
             <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-deploy-plugin</artifactId>
+                               <version>2.8.2</version>
                                <executions>
                                        <execution>
                                                <phase>deploy</phase>
@@ -102,7 +107,7 @@
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-war-plugin</artifactId>
-                               <version>2.0</version>
+                               <version>2.6</version>
                                <configuration>
                                        <webXml>
                                                ${basedir}/src/main/webapp/WEB-INF/web.xml

https://github.com/geosolutions-it/http-proxy/compare/master...marcjansen:plugin-versions

Just tell me.

mbarto commented 8 years ago

It's not intentional, so a PR is surely welcome. Thanks

marcjansen commented 8 years ago

See #41

marcjansen commented 8 years ago

Closing as #41 is merged.