search

geosolutions-it / jai-ext

Java Advanced Imaging Open Source Replacement Wannabe
Apache License 2.0
91 stars 37 forks source link

Updated to JTS 1.15.1 #196

Closed jnh5y closed 6 years ago

jnh5y commented 6 years ago

Changes to remove dependency on JTS-Examples and to allow for Windows test builds.

Signed-off-by: Jim Hughes jnh5y@ccri.com

jnh5y commented 6 years ago

Jody and I are still testing these PRs. They may not be ready to merge yet.

aaime commented 6 years ago

I had a look and did not see anything problematic, we'll wait for all the PRs to be in a mergeable state on all projects.

aaime commented 6 years ago

Build failed, cannot find JTS 1.15.1 in repos. Kicking it again.

jnh5y commented 6 years ago

@aaime thanks for kicking the build! I just got JTS 1.15.1 synced up to Maven Central a bit ago...

aaime commented 6 years ago

So now there is a fundamental problem I did not think about... this package renaming trainwreck makes the PR non mergeable on a 1.x series.... When we work on jai-ext we make a mix of small new features and bug fixes, that we then need to in stable and maintenance version of geotools and geoserver too. But the package rename is a API break, thus not backportable. Looks like we need to cut a new branch to release from, and keep two parallel builds, do backports and so on, from now on, and for a few months... gah!!!! I'll check this internally...

aaime commented 6 years ago

So we created a new 1.0.x branch, and we'll have to take on extra release and maintenance cost for around a year because of that (every time we need a fix, it's going to be merge on master, backport on 1.0.x, do two releases instead of one). Merging this one on master only.